Validate parameter name format #4799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/M
|
The following is the coverage report on the affected files.
|
chuangw6
commented
Apr 27, 2022
There was a problem hiding this comment.
additional work to be done with extractVariablesFromString function.
|
/retest |
tekton-robot
added
the
do-not-merge/work-in-progress
5 tasks
`tasks.md` mentioned that the parameter names should follow the following rules. But we didn't enforce it. - Must only contain alphanumeric characters, hyphens (-), underscores (_), and dots (.). - Must begin with a letter or an underscore (_). In this commit, we enforce the rules. If invalid name format is found, validation webhook will complain.
chuangw6
force-pushed
the
validate-param-name-format
branch
from
0aced0f to
133a5ec
Compare
tekton-robot
removed
the
do-not-merge/work-in-progress
|
The following is the coverage report on the affected files.
|
|
/test pull-tekton-pipeline-integration-tests |
vdemeester
approved these changes
May 6, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
chitrangpatel
added a commit
to chitrangpatel/pipeline
that referenced
this pull request
May 11, 2022
We want to extract everything that `NAME` contains in (`$param.<NAME> | $param.<NAME>[*]`) or (`param["<NAME>"] | $param["<NAME>"][*]`) or (`param['NAME'][*] | $param['<NAME>'][*]`). We dont want to enforce the pattern that it should follow. That part should be done by `Step 1` in tektoncd#4799 (comment) The regex pattern substitution `.*?(\[\*\])?` matches and extracts everything that is contained in `<NAME>` or `<NAME>[*]`.
5 tasks
chitrangpatel
added a commit
to chitrangpatel/pipeline
that referenced
this pull request
May 11, 2022
We want to extract everything that `NAME` contains in (`$param.<NAME> | $param.<NAME>[*]`) or (`param["<NAME>"] | $param["<NAME>"][*]`) or (`param['NAME'][*] | $param['<NAME>'][*]`). We dont want to enforce the pattern that it should follow. That part should be done by `Step 1` in tektoncd#4799 (comment) The regex pattern substitution `.*?(\[\*\])?` matches and extracts everything that is contained in `<NAME>` or `<NAME>[*]`.
chitrangpatel
added a commit
to chitrangpatel/pipeline
that referenced
this pull request
May 18, 2022
We want to extract everything that `NAME` contains in (`$param.<NAME> | $param.<NAME>[*]`) or (`param["<NAME>"] | $param["<NAME>"][*]`) or (`param['NAME'][*] | $param['<NAME>'][*]`). We dont want to enforce the pattern that it should follow. That part should be done by `Step 1` in tektoncd#4799 (comment) The regex pattern substitution `.*?(\[\*\])?` matches and extracts everything that is contained in `<NAME>` or `<NAME>[*]`.
tekton-robot
pushed a commit
that referenced
this pull request
Jul 4, 2022
We want to extract everything that `NAME` contains in (`$param.<NAME> | $param.<NAME>[*]`) or (`param["<NAME>"] | $param["<NAME>"][*]`) or (`param['NAME'][*] | $param['<NAME>'][*]`). We dont want to enforce the pattern that it should follow. That part should be done by `Step 1` in #4799 (comment) The regex pattern substitution `.*?(\[\*\])?` matches and extracts everything that is contained in `<NAME>` or `<NAME>[*]`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #4792
This doc mentioned that the parameter names should follow the following rules:
But the current code has not implemented the validation against the name format, which can cause some problems mentioned in #4792 .
In this PR, we enforce the rules. If invalid name format is found, validation webhook will complain.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
(if there are no user facing changes, use release note "NONE")
Release Notes