Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the CSI workspace type #5030

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Add support for the CSI workspace type #5030

merged 1 commit into from
Jul 12, 2022

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Jun 23, 2022 •
edited by dibyom
Loading

Changes

Adds support for CSI volumes as a workspace type.

This opens a lot of possibility as it would enable users to use alternative volumes for their workspace. An example is the Secrets Store CSI Driver to use Hashicorp Vault.

Thanks to #4825 as guidance.
Signed-off-by: JeromeJu [email protected]

/kind feature
/cc @dibyom @vdemeester

Fixes: #4446

TODO:

  • Examples
  • Docs

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

Add support to use any CSI volume driver as a workspace

@tekton-robot tekton-robot requested a review from dibyom June 23, 2022 13:44
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 23, 2022
@tekton-robot tekton-robot requested a review from vdemeester June 23, 2022 13:44
@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 23, 2022
@tekton-robot
Copy link
Collaborator

Hi @JeromeJu. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dibyom
Copy link
Member

dibyom commented Jun 23, 2022

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 23, 2022
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 24, 2022
@lbernick lbernick self-assigned this Jun 28, 2022
@dibyom
Copy link
Member

dibyom commented Jun 28, 2022

@JeromeJu looks like there is still an extra space in those generated files

lbernick
lbernick reviewed Jun 28, 2022
View reviewed changes
Copy link
Member

@lbernick lbernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in draft state so I'm guessing it's not meant to work e2e-- but if we're going to introduce support via multiple PRs we should make sure each is self contained (i.e. update the docs to indicate that this isn't fully supported, and make this clear in the commit message). If you do want to add support in a single PR, you'll likely need to make some changes here (and maybe other places as well)

examples/v1beta1/pipelineruns/no-ci/csi-workspace.yaml Show resolved Hide resolved
pkg/apis/pipeline/v1beta1/workspace_types.go Outdated Show resolved Hide resolved
pkg/apis/pipeline/v1beta1/workspace_validation.go Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2022
@JeromeJu JeromeJu force-pushed the 4446-csi-workspace branch from 151450f to 5ddc4cf Compare June 28, 2022 21:16
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 28, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/workspace/apply.go 100.0% 97.4% -2.6

@JeromeJu JeromeJu closed this Jun 29, 2022
@JeromeJu JeromeJu reopened this Jun 29, 2022
@JeromeJu JeromeJu marked this pull request as ready for review June 30, 2022 21:58
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2022
@JeromeJu JeromeJu marked this pull request as draft July 1, 2022 00:54
@dibyom dibyom mentioned this pull request Jul 8, 2022
Merged
5 tasks
@JeromeJu JeromeJu marked this pull request as ready for review July 8, 2022 15:28
dibyom
dibyom reviewed Jul 8, 2022
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JeromeJu The code looks good to me. Could we squash up the commits and add a proper commit message?

docs/install.md Show resolved Hide resolved
docs/workspaces.md Outdated Show resolved Hide resolved
docs/workspaces.md Show resolved Hide resolved
docs/workspaces.md Outdated
secretProviderClass: "vault-database"
```

Guide for the base csi workspace usage:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afrittoli @geriom @AlanGreene what's a good place for guides/tutorials/how to style docs like this one?

pkg/apis/pipeline/v1beta1/workspace_validation_test.go Outdated Show resolved Hide resolved
@JeromeJu JeromeJu force-pushed the 4446-csi-workspace branch from 7108269 to fc31bcb Compare July 8, 2022 16:31
@JeromeJu JeromeJu force-pushed the 4446-csi-workspace branch 2 times, most recently from a5d97b1 to 02d55ce Compare July 8, 2022 19:01
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2022
@JeromeJu JeromeJu force-pushed the 4446-csi-workspace branch 2 times, most recently from 07cab9a to e44f444 Compare July 11, 2022 14:39
@JeromeJu JeromeJu force-pushed the 4446-csi-workspace branch from e44f444 to 6e76e55 Compare July 11, 2022 15:34
@dibyom
Copy link
Member

dibyom commented Jul 11, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2022
@dibyom
Copy link
Member

dibyom commented Jul 12, 2022

/test pull-pipeline-kind-k8s-v1-21-e2e

@tekton-robot
Copy link
Collaborator

@dibyom: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage
  • /test pull-tekton-pipeline-kind-alpha-integration-tests
  • /test pull-tekton-pipeline-kind-alpha-yaml-tests
  • /test pull-tekton-pipeline-kind-integration-tests
  • /test pull-tekton-pipeline-kind-yaml-tests

Use /test all to run the following jobs that were automatically triggered:

  • pull-tekton-pipeline-alpha-integration-tests
  • pull-tekton-pipeline-build-tests
  • pull-tekton-pipeline-go-coverage
  • pull-tekton-pipeline-integration-tests
  • pull-tekton-pipeline-unit-tests

In response to this:

/test pull-pipeline-kind-k8s-v1-21-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afrittoli
Copy link
Member

/test pull-pipeline-kind-k8s-v1-21-e2e

@tekton-robot
Copy link
Collaborator

@afrittoli: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage
  • /test pull-tekton-pipeline-kind-alpha-integration-tests
  • /test pull-tekton-pipeline-kind-alpha-yaml-tests
  • /test pull-tekton-pipeline-kind-integration-tests
  • /test pull-tekton-pipeline-kind-yaml-tests

Use /test all to run the following jobs that were automatically triggered:

  • pull-tekton-pipeline-alpha-integration-tests
  • pull-tekton-pipeline-build-tests
  • pull-tekton-pipeline-go-coverage
  • pull-tekton-pipeline-integration-tests
  • pull-tekton-pipeline-unit-tests

In response to this:

/test pull-pipeline-kind-k8s-v1-21-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afrittoli
Copy link
Member

/test pull-pipeline-kind-k8s-v1-21-e2e

@tekton-robot
Copy link
Collaborator

@afrittoli: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage
  • /test pull-tekton-pipeline-kind-alpha-integration-tests
  • /test pull-tekton-pipeline-kind-alpha-yaml-tests
  • /test pull-tekton-pipeline-kind-integration-tests
  • /test pull-tekton-pipeline-kind-yaml-tests

Use /test all to run the following jobs that were automatically triggered:

  • pull-tekton-pipeline-alpha-integration-tests
  • pull-tekton-pipeline-build-tests
  • pull-tekton-pipeline-go-coverage
  • pull-tekton-pipeline-integration-tests
  • pull-tekton-pipeline-unit-tests

In response to this:

/test pull-pipeline-kind-k8s-v1-21-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pritidesai pritidesai added this to the Pipelines v0.38 milestone Jul 12, 2022
@afrittoli
Copy link
Member

/test pull-tekton-pipeline-build-tests

2 similar comments
@dibyom
Copy link
Member

dibyom commented Jul 12, 2022

/test pull-tekton-pipeline-build-tests

@JeromeJu
Copy link
Member Author

/test pull-tekton-pipeline-build-tests

@tekton-robot tekton-robot merged commit b7b2804 into tektoncd:main Jul 12, 2022
@JeromeJu JeromeJu mentioned this pull request Jul 25, 2022
Merged
3 tasks
@JeromeJu JeromeJu mentioned this pull request Aug 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom left review comments

@lbernick lbernick lbernick approved these changes

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@dibyom dibyom

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.38
Development

Successfully merging this pull request may close these issues.

CSI volumes as workspaces
6 participants
@JeromeJu @tekton-robot @dibyom @afrittoli @lbernick @pritidesai