Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0075: Add a pipeline run example with both object param and result #5197

Merged
merged 1 commit into from
Jul 26, 2022
Merged

TEP-0075: Add a pipeline run example with both object param and result #5197

merged 1 commit into from
Jul 26, 2022

Conversation

chuangw6
Copy link
Member

Changes

The pipeline consists of two tasks

  • task 1 writes the values of an object param to an object result.
  • task 2 uses task1's object result as the value of its own object param,
    and echo that object param.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Add a pipeline run example with both object param and result

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Jul 22, 2022
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 22, 2022
@chuangw6
Copy link
Member Author

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@chuangw6: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ywluogg
Copy link
Contributor

ywluogg commented Jul 22, 2022

/assign @ywluogg

@ywluogg
Copy link
Contributor

ywluogg commented Jul 22, 2022

Isn't https://github.com/tektoncd/pipeline/pull/5144/files a subset of these? Can they be combined?

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2022
@chuangw6
TEP-0075: Add a pipeline run example with both object param and result
df139fb 
The pipeline consists of two tasks
- task 1 writes the values of an object param to an object result.
- task 2 uses task1's object result as the value of its own object param,
and echo that object param.
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 26, 2022
@chuangw6
Copy link
Member Author

Isn't https://github.com/tektoncd/pipeline/pull/5144/files a subset of these? Can they be combined?

sg! Just removed the old one since this new file covers more use cases.

@ywluogg
Copy link
Contributor

ywluogg commented Jul 26, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2022
@tekton-robot tekton-robot merged commit ee632c1 into tektoncd:main Jul 26, 2022
@Yongxuanzhang Yongxuanzhang mentioned this pull request Sep 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernick lbernick lbernick approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@ywluogg ywluogg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chuangw6 @tekton-robot @ywluogg @lbernick