Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine changeset from build information #5311

Merged
merged 4 commits into from
Aug 17, 2022

Conversation

imjasonh
Copy link
Member

This updates knative.dev/pkg to @main to pick up a recent change to make
changeset.Get() determine the built version from information embedded in
the binary, and no longer return an error.

This also lets us remove symlinks for HEAD and refs in kodata, since
they were only there to enable the previous changeset.Get()
implementation.

#4928 recently bumped our knative/pkg dep to release-1.6 (which was the real hard part, thanks @vdemeester!). Here's the diff between release-1.6 and what we'll import now: knative/pkg@release-1.6...7b8b060

The relevant changes are knative/pkg#2548 and knative/pkg#2549

Similar change to knative/serving to drop HEAD and refs: knative/serving#13130

cc @dprotaso

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Version informaiton added to workload labels is determined from information embedded by Go, instead of relying on symlinks to Git information in our build process.

@imjasonh imjasonh requested review from vdemeester and abayer August 11, 2022 14:02
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 11, 2022
@tekton-robot tekton-robot requested review from jerop and lbernick August 11, 2022 14:02
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/pod.go 88.8% 89.3% 0.5
pkg/reconciler/taskrun/taskrun.go 80.3% 80.4% 0.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/pod.go 88.8% 89.3% 0.5
pkg/reconciler/taskrun/taskrun.go 80.3% 80.4% 0.1

@imjasonh
Copy link
Member Author

Oh, looks like tests still run with go 1.17:

go version go1.17.11 linux/amd64

We'll need to bump this to 1.18 to get this to work. Since Go only officially supports the last two versions, and 1.19 just came out, we should bump to 1.18 anyway.

@abayer
Copy link
Contributor

abayer commented Aug 15, 2022

/retest

@abayer
Copy link
Contributor

abayer commented Aug 15, 2022

...I forgot that #5134 hadn't merged yet. d'oh.

@abayer
Copy link
Contributor

abayer commented Aug 15, 2022

/retest

This updates knative.dev/pkg to @main to pick up a recent change to make
changeset.Get() determine the built version from information embedded in
the binary, and no longer return an error.

This also lets us remove symlinks for HEAD and refs in kodata, since
they were only there to enable the previous changeset.Get()
implementation.
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/pod.go 88.8% 89.3% 0.5
pkg/reconciler/taskrun/taskrun.go 80.3% 80.4% 0.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/pod.go 88.8% 89.3% 0.5
pkg/reconciler/taskrun/taskrun.go 80.3% 80.4% 0.1

@abayer
Copy link
Contributor

abayer commented Aug 16, 2022

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@abayer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abayer
Copy link
Contributor

abayer commented Aug 16, 2022

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2022
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abayer
Copy link
Contributor

abayer commented Aug 17, 2022

/retest

@tekton-robot tekton-robot merged commit 9ca006e into tektoncd:main Aug 17, 2022
@abayer abayer mentioned this pull request Aug 18, 2022
7 tasks
concaf added a commit to concaf/pipeline that referenced this pull request Jun 16, 2023
This commit removes symlinks for HEAD and refs in cmd/resolvers/kodata.
This change happened for other directories in tektoncd#5311 but this one got
left behind :)
tekton-robot pushed a commit that referenced this pull request Jun 16, 2023
This commit removes symlinks for HEAD and refs in cmd/resolvers/kodata.
This change happened for other directories in #5311 but this one got
left behind :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants