-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Determine changeset from build information #5311
Conversation
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
Oh, looks like tests still run with go 1.17:
We'll need to bump this to 1.18 to get this to work. Since Go only officially supports the last two versions, and 1.19 just came out, we should bump to 1.18 anyway. |
/retest |
...I forgot that #5134 hadn't merged yet. d'oh. |
/retest |
This updates knative.dev/pkg to @main to pick up a recent change to make changeset.Get() determine the built version from information embedded in the binary, and no longer return an error. This also lets us remove symlinks for HEAD and refs in kodata, since they were only there to enable the previous changeset.Get() implementation.
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/test check-pr-has-kind-label |
@abayer: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
This commit removes symlinks for HEAD and refs in cmd/resolvers/kodata. This change happened for other directories in tektoncd#5311 but this one got left behind :)
This commit removes symlinks for HEAD and refs in cmd/resolvers/kodata. This change happened for other directories in #5311 but this one got left behind :)
This updates knative.dev/pkg to @main to pick up a recent change to make
changeset.Get()
determine the built version from information embedded inthe binary, and no longer return an error.
This also lets us remove symlinks for HEAD and refs in kodata, since
they were only there to enable the previous
changeset.Get()
implementation.
#4928 recently bumped our knative/pkg dep to release-1.6 (which was the real hard part, thanks @vdemeester!). Here's the diff between release-1.6 and what we'll import now: knative/pkg@release-1.6...7b8b060
The relevant changes are knative/pkg#2548 and knative/pkg#2549
Similar change to knative/serving to drop HEAD and refs: knative/serving#13130
cc @dprotaso
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes