Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP-0114: Remove support for v1alpha1.Run #6508

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Conversation

lbernick
Copy link
Member

@lbernick lbernick commented Apr 7, 2023

v1alpha1.Run has been replaced by v1beta1.CustomRun, and the PipelineRun controller no longer creates v1alpha1.Run objects. This commit removes support for v1alpha1.Run in the PipelineRun controller. It maintains the API fields for v1alpha1.Run for use by clients.

Note: Retries behavior has changed between v1alpha1.Run and v1beta1.CustomRun. The PipelineRun controller does not consider whether CustomRuns have retries remaining to determine whether they have completed; it only considers their status.

/kind cleanup
Closes #6498
Closes #5870
Closes #5863

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

action required: v1alpha1.Run objects are no longer supported. You must upgrade to v1beta1.CustomRun before upgrading to this release. See https://github.com/tektoncd/pipeline/blob/main/docs/migrating-v1alpha1.Run-to-v1beta1.CustomRun.md for migration instructions

@tekton-robot tekton-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Apr 7, 2023
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 7, 2023
@lbernick lbernick changed the title [WIP] TEP-0114: Remove support for v1alpha1.Run TEP-0114: Remove support for v1alpha1.Run Apr 7, 2023
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/events/cache/cache.go 86.4% 83.3% -3.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go 85.2% 84.9% -0.3
pkg/reconciler/events/cloudevent/cloudevent.go 62.5% 63.8% 1.3
pkg/reconciler/pipelinerun/cancel.go 90.4% 93.2% 2.8
pkg/reconciler/pipelinerun/pipelinerun.go 89.4% 89.3% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.3% 96.7% 0.5
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.7% 99.5% 1.8
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 89.0% 91.8% 2.8
pkg/reconciler/pipelinerun/timeout.go 84.1% 88.2% 4.1
pkg/status/status.go 84.9% 87.2% 2.3
test/controller.go 28.2% 29.4% 1.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/events/cache/cache.go 86.4% 83.3% -3.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go 85.2% 84.9% -0.3
pkg/reconciler/events/cloudevent/cloudevent.go 62.5% 63.8% 1.3
pkg/reconciler/pipelinerun/cancel.go 90.4% 93.2% 2.8
pkg/reconciler/pipelinerun/pipelinerun.go 89.4% 89.3% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.3% 96.7% 0.5
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.7% 99.5% 1.8
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 89.0% 91.8% 2.8
pkg/reconciler/pipelinerun/timeout.go 84.1% 88.2% 4.1
pkg/status/status.go 84.9% 87.2% 2.3
test/controller.go 28.2% 29.4% 1.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/events/cache/cache.go 86.4% 83.3% -3.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go 85.2% 84.9% -0.3
pkg/reconciler/events/cloudevent/cloudevent.go 62.5% 63.8% 1.3
pkg/reconciler/pipelinerun/cancel.go 90.4% 93.2% 2.8
pkg/reconciler/pipelinerun/pipelinerun.go 89.4% 89.3% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.3% 96.7% 0.5
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.7% 99.5% 1.8
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 89.0% 91.8% 2.8
pkg/reconciler/pipelinerun/timeout.go 84.1% 88.2% 4.1
pkg/status/status.go 84.9% 87.2% 2.3
test/controller.go 28.2% 29.4% 1.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/events/cache/cache.go 86.4% 83.3% -3.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go 85.2% 84.9% -0.3
pkg/reconciler/events/cloudevent/cloudevent.go 62.5% 63.8% 1.3
pkg/reconciler/pipelinerun/cancel.go 90.4% 93.2% 2.8
pkg/reconciler/pipelinerun/pipelinerun.go 89.4% 89.3% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.3% 96.7% 0.5
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.7% 99.5% 1.8
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 89.0% 91.8% 2.8
pkg/reconciler/pipelinerun/timeout.go 84.1% 88.2% 4.1
pkg/status/status.go 84.9% 87.2% 2.3
test/controller.go 28.2% 29.4% 1.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/events/cache/cache.go 86.4% 83.3% -3.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go 85.2% 84.9% -0.3
pkg/reconciler/events/cloudevent/cloudevent.go 62.5% 63.8% 1.3
pkg/reconciler/pipelinerun/cancel.go 90.4% 93.2% 2.8
pkg/reconciler/pipelinerun/pipelinerun.go 89.4% 89.3% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.3% 96.7% 0.5
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.7% 99.5% 1.8
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 89.0% 91.8% 2.8
pkg/reconciler/pipelinerun/timeout.go 84.1% 88.2% 4.1
pkg/status/status.go 84.9% 87.2% 2.3
test/controller.go 28.2% 29.4% 1.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/events/cache/cache.go 86.4% 83.3% -3.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go 85.2% 84.9% -0.3
pkg/reconciler/events/cloudevent/cloudevent.go 62.5% 63.8% 1.3
pkg/reconciler/pipelinerun/cancel.go 90.4% 93.2% 2.8
pkg/reconciler/pipelinerun/pipelinerun.go 89.4% 89.3% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.3% 96.7% 0.5
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.7% 99.5% 1.8
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 89.0% 91.8% 2.8
pkg/reconciler/pipelinerun/timeout.go 84.1% 88.2% 4.1
pkg/status/status.go 84.9% 87.2% 2.3
test/controller.go 28.2% 29.4% 1.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/events/cache/cache.go 86.4% 83.3% -3.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go 85.2% 84.9% -0.3
pkg/reconciler/events/cloudevent/cloudevent.go 62.5% 63.8% 1.3
pkg/reconciler/pipelinerun/cancel.go 90.4% 93.2% 2.8
pkg/reconciler/pipelinerun/pipelinerun.go 89.4% 89.3% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.3% 96.7% 0.5
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.7% 99.5% 1.8
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 89.0% 91.8% 2.8
pkg/reconciler/pipelinerun/timeout.go 84.1% 88.2% 4.1
pkg/status/status.go 84.9% 87.2% 2.3
test/controller.go 28.2% 29.4% 1.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/events/cache/cache.go 86.4% 83.3% -3.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go 85.2% 84.9% -0.3
pkg/reconciler/events/cloudevent/cloudevent.go 62.5% 63.8% 1.3
pkg/reconciler/pipelinerun/cancel.go 90.4% 93.2% 2.8
pkg/reconciler/pipelinerun/pipelinerun.go 89.4% 89.3% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.3% 97.0% 0.8
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.7% 99.5% 1.8
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 89.0% 91.8% 2.8
pkg/reconciler/pipelinerun/timeout.go 84.1% 88.2% 4.1
pkg/status/status.go 84.9% 87.2% 2.3
test/controller.go 28.2% 29.4% 1.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/events/cache/cache.go 86.4% 83.3% -3.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go 85.2% 84.9% -0.3
pkg/reconciler/events/cloudevent/cloudevent.go 62.5% 63.8% 1.3
pkg/reconciler/pipelinerun/cancel.go 90.4% 93.2% 2.8
pkg/reconciler/pipelinerun/pipelinerun.go 89.4% 89.3% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.3% 97.0% 0.8
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.7% 99.5% 1.8
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 89.0% 91.8% 2.8
pkg/reconciler/pipelinerun/timeout.go 84.1% 88.2% 4.1
pkg/status/status.go 84.9% 87.2% 2.3
test/controller.go 28.2% 29.4% 1.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/events/cache/cache.go 86.4% 83.3% -3.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go 85.2% 84.9% -0.3
pkg/reconciler/events/cloudevent/cloudevent.go 62.5% 63.8% 1.3
pkg/reconciler/pipelinerun/cancel.go 90.4% 93.2% 2.8
pkg/reconciler/pipelinerun/pipelinerun.go 89.4% 89.3% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.3% 97.0% 0.8
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.7% 99.5% 1.8
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 89.0% 91.8% 2.8
pkg/reconciler/pipelinerun/timeout.go 84.1% 88.2% 4.1
pkg/status/status.go 84.9% 87.2% 2.3
test/controller.go 28.2% 29.4% 1.2

@Yongxuanzhang
Copy link
Member

Thanks! I wonder do need to remove run in config/200-clusterrole.yaml?

@lbernick
Copy link
Member Author

Thanks! I wonder do need to remove run in config/200-clusterrole.yaml?

nice catch, thanks!

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/events/cache/cache.go 86.4% 83.3% -3.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go 85.2% 84.9% -0.3
pkg/reconciler/events/cloudevent/cloudevent.go 62.5% 63.8% 1.3
pkg/reconciler/pipelinerun/cancel.go 90.4% 93.2% 2.8
pkg/reconciler/pipelinerun/pipelinerun.go 89.4% 89.3% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.3% 97.0% 0.8
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.7% 99.5% 1.8
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 89.0% 91.8% 2.8
pkg/reconciler/pipelinerun/timeout.go 84.1% 88.2% 4.1
pkg/status/status.go 84.9% 87.2% 2.3
test/controller.go 28.2% 29.4% 1.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/events/cache/cache.go 86.4% 83.3% -3.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go 85.2% 84.9% -0.3
pkg/reconciler/events/cloudevent/cloudevent.go 62.5% 63.8% 1.3
pkg/reconciler/pipelinerun/cancel.go 90.4% 93.2% 2.8
pkg/reconciler/pipelinerun/pipelinerun.go 89.4% 89.3% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.3% 97.0% 0.8
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.7% 99.5% 1.8
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 89.0% 91.8% 2.8
pkg/reconciler/pipelinerun/timeout.go 84.1% 88.2% 4.1
pkg/status/status.go 84.9% 87.2% 2.3
test/controller.go 28.2% 29.4% 1.2

Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @lbernick!

docs/customruns.md Outdated Show resolved Hide resolved
pkg/reconciler/pipelinerun/pipelinerun_test.go Outdated Show resolved Hide resolved
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2023
v1alpha1.Run has been replaced by v1beta1.CustomRun, and the PipelineRun controller no longer creates v1alpha1.Run objects.
This commit removes support for v1alpha1.Run in the PipelineRun controller.
It maintains the API fields for v1alpha1.Run for use by clients.

Note: Retries behavior has changed between v1alpha1.Run and v1beta1.CustomRun.
The PipelineRun controller does not consider whether CustomRuns have retries remaining to determine whether they have completed;
it only considers their status.
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/events/cache/cache.go 86.4% 83.3% -3.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go 85.2% 84.9% -0.3
pkg/reconciler/events/cloudevent/cloudevent.go 62.5% 63.8% 1.3
pkg/reconciler/pipelinerun/cancel.go 90.4% 93.2% 2.8
pkg/reconciler/pipelinerun/pipelinerun.go 89.4% 89.3% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.3% 97.0% 0.8
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.7% 99.5% 1.8
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 89.1% 91.8% 2.7
pkg/reconciler/pipelinerun/timeout.go 84.1% 88.2% 4.1
pkg/status/status.go 84.9% 87.2% 2.3
test/controller.go 28.2% 29.4% 1.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/events/cache/cache.go 86.4% 83.3% -3.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go 85.2% 84.9% -0.3
pkg/reconciler/events/cloudevent/cloudevent.go 62.5% 63.8% 1.3
pkg/reconciler/pipelinerun/cancel.go 90.4% 93.2% 2.8
pkg/reconciler/pipelinerun/pipelinerun.go 89.4% 89.3% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.3% 97.0% 0.8
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.7% 99.5% 1.8
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 89.1% 91.8% 2.7
pkg/reconciler/pipelinerun/timeout.go 84.1% 88.2% 4.1
pkg/status/status.go 84.9% 87.2% 2.3
test/controller.go 28.2% 29.4% 1.2

@lbernick
Copy link
Member Author

/retest

@dibyom
Copy link
Member

dibyom commented Apr 12, 2023

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2023
@lbernick lbernick closed this Apr 12, 2023
@lbernick lbernick reopened this Apr 12, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/events/cache/cache.go 86.4% 83.3% -3.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go 85.2% 84.9% -0.3
pkg/reconciler/events/cloudevent/cloudevent.go 62.5% 63.8% 1.3
pkg/reconciler/pipelinerun/cancel.go 90.4% 93.2% 2.8
pkg/reconciler/pipelinerun/pipelinerun.go 89.4% 89.3% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.3% 97.0% 0.8
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.7% 99.5% 1.8
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 89.1% 91.8% 2.7
pkg/reconciler/pipelinerun/timeout.go 84.1% 88.2% 4.1
pkg/status/status.go 84.9% 87.2% 2.3
test/controller.go 28.2% 29.4% 1.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/events/cache/cache.go 86.4% 83.3% -3.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go 85.2% 84.9% -0.3
pkg/reconciler/events/cloudevent/cloudevent.go 62.5% 63.8% 1.3
pkg/reconciler/pipelinerun/cancel.go 90.4% 93.2% 2.8
pkg/reconciler/pipelinerun/pipelinerun.go 89.4% 89.3% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.3% 97.0% 0.8
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.7% 99.5% 1.8
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 89.1% 91.8% 2.7
pkg/reconciler/pipelinerun/timeout.go 84.1% 88.2% 4.1
pkg/status/status.go 84.9% 87.2% 2.3
test/controller.go 28.2% 29.4% 1.2

@jerop
Copy link
Member

jerop commented Apr 12, 2023

/retest

@tekton-robot tekton-robot merged commit abd1849 into tektoncd:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
5 participants