-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEP-0114: Remove support for v1alpha1.Run #6508
Conversation
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
90de8f3
to
c743f4b
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
Thanks! I wonder do need to remove |
nice catch, thanks! |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @lbernick!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
v1alpha1.Run has been replaced by v1beta1.CustomRun, and the PipelineRun controller no longer creates v1alpha1.Run objects. This commit removes support for v1alpha1.Run in the PipelineRun controller. It maintains the API fields for v1alpha1.Run for use by clients. Note: Retries behavior has changed between v1alpha1.Run and v1beta1.CustomRun. The PipelineRun controller does not consider whether CustomRuns have retries remaining to determine whether they have completed; it only considers their status.
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/retest |
/lgtm |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/retest |
v1alpha1.Run has been replaced by v1beta1.CustomRun, and the PipelineRun controller no longer creates v1alpha1.Run objects. This commit removes support for v1alpha1.Run in the PipelineRun controller. It maintains the API fields for v1alpha1.Run for use by clients.
Note: Retries behavior has changed between v1alpha1.Run and v1beta1.CustomRun. The PipelineRun controller does not consider whether CustomRuns have retries remaining to determine whether they have completed; it only considers their status.
/kind cleanup
Closes #6498
Closes #5870
Closes #5863
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes