[TEP-0135] coschedule isolate pipelinerun #6929

QuanZhang-William · 2023-07-14T18:47:06Z

Changes

Part of #6740. TEP-0135 introduces a feature that allows a cluster operator to ensure that all of a PipelineRun's pods are scheduled to the same node.

This commit implements coschedule: isolate-pipelinerun coschedule mode by modifying PodAntiAffinity terms in the Affinity Assistant StatefulSets, which enforces only 1 pipelinerun is running in a node at the same time.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

tekton-robot · 2023-07-14T18:53:08Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	97.2%	97.3%	0.1

tekton-robot · 2023-07-14T18:55:30Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	97.2%	97.3%	0.1

lbernick

Thanks Quan! Can you include a release note for this feature and update the documentation to explain that it is implemented?

pkg/reconciler/pipelinerun/affinity_assistant.go

QuanZhang-William · 2023-07-17T14:59:29Z

Thanks Quan! Can you include a release note for this feature and update the documentation to explain that it is implemented?

Hi Lee! This is actually not the end to end support for coschedule-isolate-pipelinerun mode, so I don't this is the right time to update docs and release note.

Once we merged this PR, #6927 will have e2e support for all 3 modes, and we can update doc and release note in that one instead.

pkg/reconciler/pipelinerun/affinity_assistant.go

lbernick · 2023-07-17T15:03:42Z

Thanks Quan! Can you include a release note for this feature and update the documentation to explain that it is implemented?

Hi Lee! This is actually not the end to end support for coschedule-isolate-pipelinerun mode, so I don't this is the right time to update docs and release note.

Once we merged this PR, #6927 will have e2e support for all 3 modes, and we can update doc and release note in that one instead.

Oh I see, thanks. Can you update the description of #6927 (or add a comment) to explain that it depends on this PR? It's probably worth putting a hold as well.

QuanZhang-William · 2023-07-17T15:20:44Z

Thanks Quan! Can you include a release note for this feature and update the documentation to explain that it is implemented?

Hi Lee! This is actually not the end to end support for coschedule-isolate-pipelinerun mode, so I don't this is the right time to update docs and release note.
Once we merged this PR, #6927 will have e2e support for all 3 modes, and we can update doc and release note in that one instead.

Oh I see, thanks. Can you update the description of #6927 (or add a comment) to explain that it depends on this PR? It's probably worth putting a hold as well.

Comments added in #6927 (and put it on hold)

tekton-robot · 2023-07-17T15:24:56Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	97.2%	97.3%	0.1

tekton-robot · 2023-07-17T15:26:56Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	97.2%	97.3%	0.1

Yongxuanzhang · 2023-07-17T15:54:54Z

/assign

tekton-robot · 2023-07-17T16:17:16Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	97.2%	96.5%	-0.7

tekton-robot · 2023-07-17T16:18:54Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	97.2%	96.5%	-0.7

tekton-robot · 2023-07-17T16:25:05Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	97.2%	96.5%	-0.7

tekton-robot · 2023-07-17T16:28:00Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	97.2%	96.5%	-0.7

tekton-robot · 2023-07-17T16:54:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [lbernick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

QuanZhang-William · 2023-07-17T17:40:37Z

/test check-pr-has-kind-label

tekton-robot · 2023-07-17T17:40:40Z

@QuanZhang-William: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-tekton-pipeline-alpha-integration-tests
/test pull-tekton-pipeline-beta-integration-tests
/test pull-tekton-pipeline-build-tests
/test pull-tekton-pipeline-integration-tests
/test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

/test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2023-07-18T14:12:10Z

@QuanZhang-William: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-tekton-pipeline-alpha-integration-tests
/test pull-tekton-pipeline-beta-integration-tests
/test pull-tekton-pipeline-build-tests
/test pull-tekton-pipeline-integration-tests
/test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

/test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Yongxuanzhang

/lgtm

Part of [tektoncd#6740]. [TEP-0135][tep-0135] introduces a feature that allows a cluster operator to ensure that all of a PipelineRun's pods are scheduled to the same node. This commit implements `coschedule: isolate-pipelinerun` coschedule mode by modifying [PodAntiAffinity](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#inter-pod-affinity-and-anti-affinity) terms in the `Affinity Assistant StatefulSets`, which enforces only 1 pipelinerun is running in a node at the same time. /kind feature [tektoncd#6740]: tektoncd#6740 [tep-0135]: https://github.com/tektoncd/community/blob/main/teps/0135-coscheduling-pipelinerun-pods.md

tekton-robot · 2023-07-19T14:37:01Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	97.2%	96.5%	-0.7

tekton-robot · 2023-07-19T14:38:51Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	97.2%	96.5%	-0.7

Yongxuanzhang · 2023-07-19T15:33:20Z

/lgtm

tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 14, 2023

tekton-robot requested review from bobcatfish and dibyom July 14, 2023 18:47

QuanZhang-William mentioned this pull request Jul 14, 2023

[TEP-0135] Coschedule per (Isolated) PipelineRun e2e support #6927

Merged

7 tasks

lbernick self-assigned this Jul 17, 2023

lbernick reviewed Jul 17, 2023

View reviewed changes

pkg/reconciler/pipelinerun/affinity_assistant.go Show resolved Hide resolved

pkg/reconciler/pipelinerun/affinity_assistant.go Show resolved Hide resolved

lbernick reviewed Jul 17, 2023

View reviewed changes

pkg/reconciler/pipelinerun/affinity_assistant.go Outdated Show resolved Hide resolved

QuanZhang-William force-pushed the tep-0135-isolate-pipelinerun branch from 081bb0a to f858594 Compare July 17, 2023 15:18

tekton-robot assigned Yongxuanzhang Jul 17, 2023

QuanZhang-William force-pushed the tep-0135-isolate-pipelinerun branch from f858594 to 3afac06 Compare July 17, 2023 16:10

QuanZhang-William force-pushed the tep-0135-isolate-pipelinerun branch from 3afac06 to 4b131a4 Compare July 17, 2023 16:19

lbernick approved these changes Jul 17, 2023

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2023

Yongxuanzhang reviewed Jul 18, 2023

View reviewed changes

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2023

QuanZhang-William force-pushed the tep-0135-isolate-pipelinerun branch from 4b131a4 to c979df7 Compare July 19, 2023 14:31

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2023

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2023

tekton-robot merged commit 0b95e49 into tektoncd:main Jul 19, 2023

QuanZhang-William mentioned this pull request Jul 25, 2023

TEP-0135: Coscheduling PipelineRun pods Implementation #6740

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TEP-0135] coschedule isolate pipelinerun #6929

[TEP-0135] coschedule isolate pipelinerun #6929

QuanZhang-William commented Jul 14, 2023

tekton-robot commented Jul 14, 2023

tekton-robot commented Jul 14, 2023

lbernick left a comment

QuanZhang-William commented Jul 17, 2023

lbernick commented Jul 17, 2023

QuanZhang-William commented Jul 17, 2023

tekton-robot commented Jul 17, 2023

tekton-robot commented Jul 17, 2023

Yongxuanzhang commented Jul 17, 2023

tekton-robot commented Jul 17, 2023

tekton-robot commented Jul 17, 2023

tekton-robot commented Jul 17, 2023

tekton-robot commented Jul 17, 2023

tekton-robot commented Jul 17, 2023

QuanZhang-William commented Jul 17, 2023

tekton-robot commented Jul 17, 2023

tekton-robot commented Jul 18, 2023

Yongxuanzhang left a comment

tekton-robot commented Jul 19, 2023

tekton-robot commented Jul 19, 2023

Yongxuanzhang commented Jul 19, 2023

[TEP-0135] coschedule isolate pipelinerun #6929

[TEP-0135] coschedule isolate pipelinerun #6929

Conversation

QuanZhang-William commented Jul 14, 2023

Changes

Submitter Checklist

Release Notes

tekton-robot commented Jul 14, 2023

tekton-robot commented Jul 14, 2023

lbernick left a comment

Choose a reason for hiding this comment

QuanZhang-William commented Jul 17, 2023

lbernick commented Jul 17, 2023

QuanZhang-William commented Jul 17, 2023

tekton-robot commented Jul 17, 2023

tekton-robot commented Jul 17, 2023

Yongxuanzhang commented Jul 17, 2023

tekton-robot commented Jul 17, 2023

tekton-robot commented Jul 17, 2023

tekton-robot commented Jul 17, 2023

tekton-robot commented Jul 17, 2023

tekton-robot commented Jul 17, 2023

QuanZhang-William commented Jul 17, 2023

tekton-robot commented Jul 17, 2023

tekton-robot commented Jul 18, 2023

Yongxuanzhang left a comment

Choose a reason for hiding this comment

tekton-robot commented Jul 19, 2023

tekton-robot commented Jul 19, 2023

Yongxuanzhang commented Jul 19, 2023