-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace redundant function CheckAlphaOrBetaFields #6934
Conversation
Most existing validation code uses `version.ValidateEnabledAPIFields` to validate that "enable-api-fields" is set to the correct value for the feature in question. This commit removes the few usages of config.CheckAlphaOrBetaFields in favor of version.ValidateEnabledAPIFields, which provides the same functionality.
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/assign |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/retest
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JeromeJu, jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test check-pr-has-kind-label |
@dibyom: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Most existing validation code uses
version.ValidateEnabledAPIFields
to validate that "enable-api-fields" is set to the correct value for the feature in question. This commit removes the few usages of config.CheckAlphaOrBetaFields in favor of version.ValidateEnabledAPIFields, which provides the same functionality./kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes