-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a section for installing Tekton Pipelines on OpenShift #699
Add a section for installing Tekton Pipelines on OpenShift #699
Conversation
Outlines how to add the anyuid scc to the tekton-pipelines-controller SA in order to successfully get the webhook pod to start. Clarifies tektoncd#609
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
docs/install.md
Outdated
```bash | ||
oc get pods --namespace tekton-pipelines --watch | ||
``` | ||
|
||
You are now ready to create and run Tekton Pipelines: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually we may want to move ### Installing Tekton Pipelines on OpenShift
just before ## Configuring Tekton Pipelines
(:angel: so that You are now ready to …
is not under the Openshift
heading)
/ok-to-test |
|
||
```bash | ||
oc new project tekton-pipelines | ||
oc adm policy add-scc-to-user anyuid -z tekton-pipelines-controller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These commands requires admin privileges, is it better to add a note?
Or
Shall we add oc login as admin
instruction as the first step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we also need the hack cluster-admin
priv oc adm policy add-cluster-role-to-user cluster-admin -z tekton-pipelines-controller -n tekton-pipelines
, don't we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my testing, I only needed anyuid for the tekton-pipelines-controller
sa.
…move the installation steps
/test pull-tekton-pipeline-integration-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tomgeorge, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-tekton-pipeline-integration-tests |
Changes
Add a section for installing Tekton Pipelines on OpenShift
Outlines how to add the anyuid scc to the tekton-pipelines-controller SA in order to successfully get the webhook pod to start.
Clarifies #609
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
Release Notes