Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark disable-affinity-assistant as deprecated #6991

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Mark disable-affinity-assistant as deprecated #6991

merged 1 commit into from
Jul 31, 2023

Conversation

QuanZhang-William
Copy link
Member

@QuanZhang-William QuanZhang-William commented Jul 27, 2023 •
edited
Loading

Changes

This commit marks the disable-affinity-assistant feature flag as deprecated in favor of the new coschedule feature flag. See migration plan in https://github.com/tektoncd/pipeline/blob/main/docs/affinityassistants.md

Part of #6988

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

action required: The `disable-affinity-assistant` feature flag is deprecated in favour of the new `coschedule` feature flag. The `disable-affinity-assistant` feature flag will be removed in 9 months. 
The Affinity Assistant behaviour should now be configured by the `coschedule` feature flag.

@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. labels Jul 27, 2023
@tekton-robot tekton-robot requested review from jerop and lbernick July 27, 2023 19:49
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 27, 2023
@QuanZhang-William QuanZhang-William mentioned this pull request Jul 27, 2023
Closed
lbernick
lbernick reviewed Jul 27, 2023
View reviewed changes
Copy link
Member

@lbernick lbernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/tektoncd/pipeline/blob/main/docs/affinityassistants.md currently states "In 9 months, the disable-affinity-assistant feature flag will be deprecated". Can you update this to clarify that the disable-affinity-assistant flag is deprecated and will be removed in 9 months? And can you please also update the other places this configuration is specified (https://github.com/tektoncd/pipeline/blob/main/docs/additional-configs.md#customizing-the-pipelines-controller-behavior, https://github.com/tektoncd/pipeline/blob/main/config/config-feature-flags.yaml) to clarify that this is deprecated?

docs/deprecations.md Outdated Show resolved Hide resolved
@lbernick
Copy link
Member

I think integration test failures are due to #6992

@QuanZhang-William QuanZhang-William force-pushed the tep-0135-deprecate-disable-affinity-assistant branch from 7c75ec7 to 3d90932 Compare July 27, 2023 21:07
@QuanZhang-William
Copy link
Member Author

https://github.com/tektoncd/pipeline/blob/main/docs/affinityassistants.md currently states "In 9 months, the disable-affinity-assistant feature flag will be deprecated". Can you update this to clarify that the disable-affinity-assistant flag is deprecated and will be removed in 9 months? And can you please also update the other places this configuration is specified (https://github.com/tektoncd/pipeline/blob/main/docs/additional-configs.md#customizing-the-pipelines-controller-behavior, https://github.com/tektoncd/pipeline/blob/main/config/config-feature-flags.yaml) to clarify that this is deprecated?

Thanks, clarification added

@QuanZhang-William QuanZhang-William force-pushed the tep-0135-deprecate-disable-affinity-assistant branch from 3d90932 to 2ab9266 Compare July 27, 2023 21:30
lbernick
lbernick reviewed Jul 27, 2023
View reviewed changes
Copy link
Member

@lbernick lbernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for one more request-- I think having "in 9 months" is confusing in markdown files since we won't be continually updating them, can you swap to saying "in release v0.60"?

@QuanZhang-William
Copy link
Member Author

Sorry for one more request-- I think having "in 9 months" is confusing in markdown files since we won't be continually updating them, can you swap to saying "in release v0.60"?

No problem, changed. BTW, was wondering is there a place we can check future release plan?

@QuanZhang-William
Mark disable-affinity-assistant as deprecated
bb4c55a 
This commit marks the `disable-affinity-assistant` feature flag as deprecated in favor of the new `coschedule` feature flag.
See migration plan in https://github.com/tektoncd/pipeline/blob/main/docs/affinityassistants.md

/kind misc
@QuanZhang-William QuanZhang-William force-pushed the tep-0135-deprecate-disable-affinity-assistant branch 2 times, most recently from 945b418 to bb4c55a Compare July 28, 2023 14:19
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2023
@lbernick
Copy link
Member

Sorry for one more request-- I think having "in 9 months" is confusing in markdown files since we won't be continually updating them, can you swap to saying "in release v0.60"?

No problem, changed. BTW, was wondering is there a place we can check future release plan?

You can take a look at the milestones (https://github.com/tektoncd/pipeline/milestones) or the release rotation in the pipelines wg notes

@QuanZhang-William
Copy link
Member Author

QuanZhang-William commented Jul 31, 2023 •
edited
Loading

/test pull-tekton-pipeline-alpha-integration-tests

@JeromeJu
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@tekton-robot tekton-robot merged commit 9a64253 into tektoncd:main Jul 31, 2023
@Richard87 Richard87 mentioned this pull request Nov 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernick lbernick lbernick approved these changes

@jerop jerop Awaiting requested review from jerop

Assignees

@JeromeJu JeromeJu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QuanZhang-William @lbernick @tekton-robot @JeromeJu