Updating some tests to not require the docker socket #716
Conversation
googlebot
added
the
cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
size/M
|
Nice one @vdemeester ! I'm happy with it, makes sense to me :D I've always used kaniko (probably cuz my team made it hahaha) but I'm happy to see some variety in our examples :D /meow space |
|
@bobcatfish: Bad category. Please see https://api.thecatapi.com/api/categories/list In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
ಠ_ಠ |
|
/meow space |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
vdemeester
force-pushed
the
e2e-pipelinerun-do-not-assume-cri-docker
branch
from
14b1f24 to
c0edd86
Compare
vdemeester
force-pushed
the
e2e-pipelinerun-do-not-assume-cri-docker
branch
from
c0edd86 to
bcc3904
Compare
We should try to avoid, as much as possible, to assume that there will be a docker socket available on the node. If the runtime used by Kubernetes is not Docker, this fails. This affects : TestPipelineRun and private-taskrun and taskrun-docker-basic examples. Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
e2e-pipelinerun-do-not-assume-cri-docker
branch
from
bcc3904 to
e99d663
Compare
|
/lgtm |
Changes
We should try to avoid, as much as possible, to assume that there will
be a docker socket available on the node. If the runtime used by
Kubernetes is not Docker, this fails.
This affects : TestPipelineRun and private-taskrun and
taskrun-docker-basic examples.
quay.io/rhpipeline/buildahis not completely optimized (we may want a lighter image) — usingskopeoit's lighter and easier to run in userspace.Signed-off-by: Vincent Demeester [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
[ ] Includes docs (if user facing)See the contribution guide
for more details.