Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sample yaml #762

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Fix sample yaml #762

merged 1 commit into from
Apr 15, 2019
+16 −7

Conversation

piyush-garg
Copy link
Contributor

Yaml provided as a sample have missing property
and are confusing the users

Fix them to avoid confusions and also used the
consistent naming

Fixes #755

@piyush-garg
Fix sample yaml
567509e 
Yaml provided as a sample have missing property
and are confusing the users

Fix them to avoid confusions and also used the
consistent naming

Fixes tektoncd#755
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Apr 15, 2019
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 15, 2019
@chmouel
Copy link
Member

chmouel commented Apr 15, 2019

awesome 👍

@vdemeester
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 15, 2019
@dlorenc
Copy link
Contributor

dlorenc commented Apr 15, 2019

/test pull-tekton-pipeline-integration-tests

vdemeester
vdemeester reviewed Apr 15, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
cc @bobcatfish for 2nd read 😅

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2019
@bobcatfish
Copy link
Collaborator

This is great, thanks so much for catching and fixing this @piyush-garg !!! ❤️❤️❤️

/approve
/meow space

@tekton-robot
Copy link
Collaborator

@bobcatfish: cat image

In response to this:

This is great, thanks so much for catching and fixing this @piyush-garg !!! ❤️❤️❤️

/approve
/meow space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish, piyush-garg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2019
@tekton-robot tekton-robot merged commit 385a537 into tektoncd:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester left review comments

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"From" does not work
7 participants
@piyush-garg @chmouel @vdemeester @dlorenc @bobcatfish @tekton-robot @googlebot