Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable flakey test so I can see it in action 🤓 #769

Closed
wants to merge 2 commits into from
Closed

Re-enable flakey test so I can see it in action 🤓 #769

wants to merge 2 commits into from

Conversation

bobcatfish
Copy link
Collaborator

@bobcatfish bobcatfish commented Apr 17, 2019 •
edited
Loading

Investigating #731

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Apr 17, 2019
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2019
@bobcatfish
Copy link
Collaborator Author

so ... many things seem to have gone wrong that are completely unrelated ...

@bobcatfish
Copy link
Collaborator Author

image

@bobcatfish
Copy link
Collaborator Author

sooooo TestHelmDeployPipelineRun failed.... whaaaaaat
and TestTaskRunTimeout passed...

@bobcatfish
Copy link
Collaborator Author

AGAIN WITH FEELING

/test pull-tekton-pipeline-integration-tests

@bobcatfish
Copy link
Collaborator Author 

I0417 23:12:04.276] --- PASS: TestTaskRunTimeout (32.20s)

ಠ_ಠ

/test pull-tekton-pipeline-integration-tests

@bobcatfish
Copy link
Collaborator Author 

I0417 23:45:20.425] --- FAIL: TestTaskRunTimeout (601.20s)

yaaaaay it's real

@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2019
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 18, 2019
@bobcatfish
Copy link
Collaborator Author

/test pull-tekton-pipeline-integration-tests

@bobcatfish
Copy link
Collaborator Author

via #771 i have a strong theory about what's going on, will update #731 👯‍♀️

@bobcatfish bobcatfish closed this Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjasonh imjasonh Awaiting requested review from imjasonh

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bobcatfish @tekton-robot @googlebot