-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Boskos StatefulSet with Deployment #193
Comments
/kind feature |
This change deploys Boskos as a Deployment rather than a StatefulSet, to enable quicker feedback in the deployment process, and removing the need to delete the Boskos pods before new pods are started. This addresses tektoncd#193 Signed-off-by: Tom George <[email protected]>
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
@bobcatfish is this something we still need to fix? |
@afrittoli yeah, esp. since it looks like we're for sure going to be using boskos in the future. @tomgeorge even has the solution in #225, we just need to verify that it works. I can add this to my todo list! |
This change deploys Boskos as a Deployment rather than a StatefulSet, to enable quicker feedback in the deployment process, and removing the need to delete the Boskos pods before new pods are started. This addresses tektoncd#193 Signed-off-by: Tom George <[email protected]>
This change deploys Boskos as a Deployment rather than a StatefulSet, to enable quicker feedback in the deployment process, and removing the need to delete the Boskos pods before new pods are started. This addresses #193 Signed-off-by: Tom George <[email protected]>
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
feels like something we should do but if it's not important enough then maybe it's not worth it |
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
@tekton-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Expected Behavior
If you make changes to the boskos configuration and apply it, you should be able to see the changes in the resulting pod.
Actual Behavior
The boskos StatefulSet has update strategy "ondelete" so you have to delete the pod before it'll get the update.
Steps to Reproduce the Problem
Additional Info
The k8s prow folks seem to have gone through this same cycle kubernetes/test-infra#11956 and are now using a Deployment (and they got rid of the PVC as well) https://github.com/kubernetes/test-infra/pull/13594/files
The text was updated successfully, but these errors were encountered: