Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Boskos StatefulSet with Deployment #193

Closed
bobcatfish opened this issue Jan 21, 2020 · 9 comments
Closed

Replace Boskos StatefulSet with Deployment #193

bobcatfish opened this issue Jan 21, 2020 · 9 comments
Labels
area/test-infra Issues or PRs related to the testing infrastructure kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@bobcatfish
Copy link
Contributor

Expected Behavior

If you make changes to the boskos configuration and apply it, you should be able to see the changes in the resulting pod.

Actual Behavior

The boskos StatefulSet has update strategy "ondelete" so you have to delete the pod before it'll get the update.

Steps to Reproduce the Problem

  1. Change the image in boskos/boskos.yaml
  2. Apply the config
  3. Watch nothing happen

Additional Info

The k8s prow folks seem to have gone through this same cycle kubernetes/test-infra#11956 and are now using a Deployment (and they got rid of the PVC as well) https://github.com/kubernetes/test-infra/pull/13594/files

@vdemeester
Copy link
Member

/kind feature
/area test-infra

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. area/test-infra Issues or PRs related to the testing infrastructure labels Jan 22, 2020
tomgeorge added a commit to tomgeorge/plumbing that referenced this issue Feb 9, 2020
This change deploys Boskos as a Deployment rather than a StatefulSet, to enable quicker feedback in the deployment process, and removing
the need to delete the Boskos pods before new pods are started.

This addresses tektoncd#193

Signed-off-by: Tom George <[email protected]>
@tekton-robot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 13, 2020
@afrittoli
Copy link
Member

@bobcatfish is this something we still need to fix?

@bobcatfish
Copy link
Contributor Author

@afrittoli yeah, esp. since it looks like we're for sure going to be using boskos in the future. @tomgeorge even has the solution in #225, we just need to verify that it works. I can add this to my todo list!

@bobcatfish bobcatfish self-assigned this Aug 13, 2020
@dibyom dibyom removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 14, 2020
tomgeorge added a commit to tomgeorge/plumbing that referenced this issue Sep 14, 2020
This change deploys Boskos as a Deployment rather than a StatefulSet, to enable quicker feedback in the deployment process, and removing
the need to delete the Boskos pods before new pods are started.

This addresses tektoncd#193

Signed-off-by: Tom George <[email protected]>
tekton-robot pushed a commit that referenced this issue Sep 15, 2020
This change deploys Boskos as a Deployment rather than a StatefulSet, to enable quicker feedback in the deployment process, and removing
the need to delete the Boskos pods before new pods are started.

This addresses #193

Signed-off-by: Tom George <[email protected]>
@bobcatfish bobcatfish removed their assignment Nov 3, 2020
@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 1, 2021
@tekton-robot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 3, 2021
@bobcatfish
Copy link
Contributor Author

feels like something we should do but if it's not important enough then maybe it's not worth it

@tekton-robot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test-infra Issues or PRs related to the testing infrastructure kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants