Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better name for TriggerTemplate? #201

Closed
bobcatfish opened this issue Nov 1, 2019 · 8 comments
Closed

Better name for TriggerTemplate? #201

bobcatfish opened this issue Nov 1, 2019 · 8 comments
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@bobcatfish
Copy link
Collaborator

Expected Behavior

TriggerTemplate is a pretty cool idea, which has the potential for being used beyond just in triggers b/c folks may have all kinds of circumstances in which they want to create instances of CRDs.

For example in #200 @skaegi is requesting a way to invoke a TriggerTemplate without any kind of EventListener and in the PipelineResource redesign I think TriggerTemplates could be a cool way to express how to create new instances of PipelineResources when created or mutated.

Actual Behavior

The name TriggerTemplates pretty much indicates this is part of triggering, and that's all its good for.

Additional Info

Some name ideas:

  • ResourceTemplate <-- cuz we define how to create resources
  • ResourceFactory <-- ah god the java - but factory isnt a bad name imo!
  • ResourceCreator <-- i dunno
  • Template <-- maybe too generic
  • FromParamsToResource <-- .... okay ill stopp

Also in #200 @skaegi is proposing adding Run to the name of whatever this is called, might be interesting to brainstorm what the invocation of this thing could be called also.

p.s. @dibyom @wlynch @vtereso @ncskier @iancoffey if you folks agree with this, renaming before 0.2 could be good

@vtereso
Copy link

vtereso commented Nov 11, 2019

In deciding this, I think we should confirm whether we will or will not be opening templates to create any (or most) kind(s) of resources since that seems significant to the name (e.g. TektonTemplate vs ResourceTemplate).

Currently templates inject parameters as well as references via the $(uid) interpolation variable. In a world where run resources do not reference other event time resources (parameter passing only), the definition/function of a template would still creates Kubernetes resources, but not PipelineResources. For this reason, I think including names like ResourceFactory could be confusing. This aside, I am mostly indifferent about the naming.

@dibyom
Copy link
Member

dibyom commented Nov 26, 2019

ResourceTemplate <-- cuz we define how to create resources

Currently, TriggerTemplates contain a field called ResourceTemplates containing the raw template

@dibyom
Copy link
Member

dibyom commented Jan 23, 2020

/area api

@dibyom dibyom added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jan 23, 2020
@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 13, 2020
@tekton-robot
Copy link

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 13, 2020
@dibyom
Copy link
Member

dibyom commented Aug 14, 2020

ref #697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants