-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better name for TriggerTemplate? #201
Comments
In deciding this, I think we should confirm whether we will or will not be opening templates to create any (or most) kind(s) of resources since that seems significant to the name (e.g. Currently templates inject parameters as well as references via the |
Currently, TriggerTemplates contain a field called |
/area api |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
@tekton-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ref #697 |
Expected Behavior
TriggerTemplate
is a pretty cool idea, which has the potential for being used beyond just intriggers
b/c folks may have all kinds of circumstances in which they want to create instances of CRDs.For example in #200 @skaegi is requesting a way to invoke a
TriggerTemplate
without any kind ofEventListener
and in the PipelineResource redesign I thinkTriggerTemplates
could be a cool way to express how to create new instances ofPipelineResources
when created or mutated.Actual Behavior
The name
TriggerTemplates
pretty much indicates this is part of triggering, and that's all its good for.Additional Info
Some name ideas:
ResourceTemplate
<-- cuz we define how to create resourcesResourceFactory
<-- ah god the java - but factory isnt a bad name imo!ResourceCreator
<-- i dunnoTemplate
<-- maybe too genericFromParamsToResource
<-- .... okay ill stoppAlso in #200 @skaegi is proposing adding
Run
to the name of whatever this is called, might be interesting to brainstorm what the invocation of this thing could be called also.p.s. @dibyom @wlynch @vtereso @ncskier @iancoffey if you folks agree with this, renaming before 0.2 could be good
The text was updated successfully, but these errors were encountered: