Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple interceptors #249

Closed
dibyom opened this issue Dec 3, 2019 · 2 comments · Fixed by #272
Closed

Support multiple interceptors #249

dibyom opened this issue Dec 3, 2019 · 2 comments · Fixed by #272
Assignees
@wlynch
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature.
Milestone
Triggers 0.2

Comments

@dibyom
Copy link
Member

dibyom commented Dec 3, 2019 •
edited
Loading

Expected Behavior

A trigger can specify multiple interceptors.

Actual Behavior

A trigger can only have a single interceptor.

Additional Info

Would be needed if we go with Option 3 from the Filters design doc (#49)
@dibyom dibyom added kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Dec 3, 2019
@wlynch
Copy link
Member

wlynch commented Dec 6, 2019

I'm happy to pick this up.

/assign wlynch

@dibyom dibyom added this to the Triggers 0.2 milestone Dec 9, 2019
@dibyom
Copy link
Member Author

dibyom commented Dec 9, 2019

Adding this to 0.2 Milestone since this will be needed for Filters as Interceptors approach from #49 (comment)

@wlynch wlynch mentioned this issue Dec 11, 2019
Merged
3 tasks
@wlynch wlynch mentioned this issue Dec 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wlynch wlynch

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
Triggers 0.2
Development

Successfully merging a pull request may close this issue.

Add support for multiple interceptors. wlynch/triggers
2 participants
@wlynch @dibyom