Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate trigger.interceptor #290

Closed
wlynch opened this issue Dec 19, 2019 · 1 comment · Fixed by #425
Closed

Deprecate trigger.interceptor #290

wlynch opened this issue Dec 19, 2019 · 1 comment · Fixed by #425
Assignees
@piyush-garg
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
Triggers 0.3

Comments

@wlynch
Copy link
Member

wlynch commented Dec 19, 2019

Expected Behavior

Users should use interceptors instead of interceptor. In #272 we support upgrading interceptor => interceptors, but we will want to remove compatibility for 0.3.x

Additional Info

This is in preparation of #249, #272
@dibyom dibyom added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 20, 2019
@dibyom dibyom added this to the Triggers 0.3 milestone Jan 21, 2020
@piyush-garg
Copy link
Contributor

/assign

piyush-garg added a commit to piyush-garg/triggers that referenced this issue Feb 7, 2020
@piyush-garg
Remove deprecated Interceptor
5ec7b36 
This will the deprecated field interceptor which
has been deprecated in 0.2 release in favor of
interceptors

Fix tektoncd#290
@piyush-garg piyush-garg mentioned this issue Feb 7, 2020
Merged
3 tasks
tekton-robot pushed a commit that referenced this issue Feb 7, 2020
@piyush-garg @tekton-robot
Remove deprecated Interceptor
ece7da5 
This will the deprecated field interceptor which
has been deprecated in 0.2 release in favor of
interceptors

Fix #290
piyush-garg pushed a commit to piyush-garg/triggers that referenced this issue Dec 21, 2020
@openshift-merge-robot
Merge pull request tektoncd#290 from pradeepitm12/rm-run-as-user
941a72a 
fix ci remove runAsUser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piyush-garg piyush-garg

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
Triggers 0.3
Development

Successfully merging a pull request may close this issue.

Remove deprecated Interceptor piyush-garg/triggers
3 participants
@wlynch @dibyom @piyush-garg