Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split out Test_NewResources into smaller tests #252

Closed
dibyom opened this issue Dec 6, 2019 · 0 comments · Fixed by #321
Closed

Split out Test_NewResources into smaller tests #252

dibyom opened this issue Dec 6, 2019 · 0 comments · Fixed by #321
Assignees
@dibyom
Labels
area/testing Issues or PRs related to testing

Comments

@dibyom
Copy link
Member

dibyom commented Dec 6, 2019

template/event_test.go contains a Test_NewResources function that tests both ResolveParams and ResolveResources. So, there is quite a bit of setup required to test each function.

We should separate it out into smaller tests that test each of those two exported functions separately
@dibyom dibyom added the area/testing Issues or PRs related to testing label Dec 6, 2019
@dibyom dibyom self-assigned this Dec 6, 2019
@dibyom dibyom mentioned this issue Dec 10, 2019
Merged
3 tasks
dibyom added a commit to dibyom/triggers that referenced this issue Jan 7, 2020
@dibyom
Split Test_NewResources into smaller tests
e7efa27 
We used to have a function called NewResources that we later split into
smaller functions -- ResolveParams and ResolveResources. However, in our
unit tests, we kept the Test_NewResources function leading to tests that
were more verbose/needed more setup than necessary. This commit splits
the tests into smaller more targeted tests.

Fixes tektoncd#252

Signed-off-by: Dibyo Mukherjee <[email protected]>
@dibyom dibyom mentioned this issue Jan 7, 2020
Merged
3 tasks
dibyom added a commit to dibyom/triggers that referenced this issue Jan 7, 2020
@dibyom
Split Test_NewResources into smaller tests
e7a6c2b 
We used to have a function called NewResources that we later split into
smaller functions -- ResolveParams and ResolveResources. However, in our
unit tests, we kept the Test_NewResources function leading to tests that
were more verbose/needed more setup than necessary. This commit splits
the tests into smaller more targeted tests.

Fixes tektoncd#252

Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom added a commit to dibyom/triggers that referenced this issue Jan 7, 2020
@dibyom
Split Test_NewResources into smaller tests
7e38ba4 
We used to have a function called NewResources that we later split into
smaller functions -- ResolveParams and ResolveResources. However, in our
unit tests, we kept the Test_NewResources function leading to tests that
were more verbose/needed more setup than necessary. This commit splits
the tests into smaller more targeted tests.

Fixes tektoncd#252

Signed-off-by: Dibyo Mukherjee <[email protected]>
tekton-robot pushed a commit that referenced this issue Jan 8, 2020
@dibyom @tekton-robot
Split Test_NewResources into smaller tests
256c7e4 
We used to have a function called NewResources that we later split into
smaller functions -- ResolveParams and ResolveResources. However, in our
unit tests, we kept the Test_NewResources function leading to tests that
were more verbose/needed more setup than necessary. This commit splits
the tests into smaller more targeted tests.

Fixes #252

Signed-off-by: Dibyo Mukherjee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dibyom dibyom

Labels
area/testing Issues or PRs related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split Test_NewResources into smaller tests dibyom/triggers
1 participant
@dibyom