-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent types for Header values extracted from bindings #260
Comments
Possibly a good first task? Affected tests are https://github.com/tektoncd/triggers/blob/master/pkg/template/event.go#L151 and https://github.com/tektoncd/triggers/blob/master/pkg/template/event_test.go#L597 |
Hey @bigkevmcd I think #241 should fix this actually |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
@tekton-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If I use
$(header)
, the values are an array of strings. If I use$(header.key)
, the values are string.I noticed this when working on #241. I think using strings instead of arrays would be the more expected behavior. This is also the behavior we use in most cases.
The text was updated successfully, but these errors were encountered: