Add interceptor headers to optionally pass trigger specific information #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/L
vtereso
force-pushed
the
InterceptorHeaders
branch
4 times, most recently
from
9c4cdb7 to
f8ee516
Compare
vtereso
force-pushed
the
InterceptorHeaders
branch
from
f8ee516 to
f801a81
Compare
ncskier
approved these changes
Oct 10, 2019
There was a problem hiding this comment.
Thanks @vtereso looks great!
I think it could end up being a little weird using []pipelinev1.Params as the Headers since we use the Array type here, but nowhere else in Triggers; however, I think this is a separate concern of mine about our Triggers parameters that is unrelated to this PR.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncskier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes: #158
Add interceptor headers
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.