Add event type filtering to the gitlab interceptor. #235
Conversation
This mirrors the event type fltering that exists for Github.
tekton-robot
added
the
size/L
|
The following is the coverage report on pkg/.
|
| if subtle.ConstantTimeCompare([]byte(header), secretToken) == 0 { | ||
| return nil, errors.New("Invalid X-Gitlab-Token") | ||
| // Make sure to use a constant time comparison here. | ||
| if subtle.ConstantTimeCompare([]byte(header), secretToken) == 0 { |
| @@ -7517,4 +7517,3 @@ Import: github.com/tektoncd/triggers/vendor/knative.dev/pkg | |||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |||
| See the License for the specific language governing permissions and | |||
| limitations under the License. | |||
|
|
|||
There was a problem hiding this comment.
Not sure if this was intentional?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm LGTM, though once we have expression filtering (#49), we may want to consider removing this event filtering from the interceptor. I think it might be clearer / more consistent to have all "if field matches foo" logic to live in the expression, since it will be a more general and flexible location for that to be done. Since it doesn't exist yet, this is fine for now! ^_^ |
Changes
This mirrors the event type fltering that exists for Github.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes