-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use another NodeSelector value in EventListener tests #720
Conversation
NodeSelector values are changed for 2 tests from beta.kubernetes.io/arch=amd64 to beta.kubernetes.io/os=linux to let e2e tests pass on non amd64 architecture (s390x, ppc64le, etc) Fix: tektoncd#718 Signed-off-by: Yulia Gaponenko <[email protected]>
Hi @barthy1. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test pull-tekton-triggers-integration-tests |
Seems to be some common env problem with integration tests? I can see in the logs
|
/test pull-tekton-triggers-integration-tests |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
NodeSelector values are changed for 2 tests from beta.kubernetes.io/arch=amd64
to beta.kubernetes.io/os=linux to let e2e tests pass on non amd64
architecture (s390x, ppc64le, etc)
Fix: #718
Signed-off-by: Yulia Gaponenko [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes