Add vars parameter to user_template and user modules #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! @schurzi, can you do a test? |
|
Hi, any news on merging my PR? thanks |
rndmh3ro
approved these changes
Oct 28, 2024
|
Needs #265 but then this can be merged. |
rndmh3ro
approved these changes
Oct 29, 2024
schurzi
approved these changes
Oct 29, 2024
schurzi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
few days ago I needed to add a user template and a user to director with some vars, but I found out that the parameter wasn't implemented or the modules, so I simply implemented that along with examples and other updates.
Can you please review my mods?
I have only tested today with last version of Director/Icinga2 and it worked
Thanks