fix: fixed edge-case where events would be set to failed if hazelcast instance is not active #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instance is not active
ledex
requested review from
mherwig and
Th3Shadowbroker
and removed request for
a team
|
mherwig
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an edge case where events would be set to 'FAILED' if the hazelcast instance used for the deduplication cache is not active/reachable/etc. Instead, we now deliver the events anyway, without checking for duplicates. As Horizon is built for 'at least once' delivery, and consumers need to be idempotent, this should be no problem.
For writing events in the deduplication cache this is already implemented.