Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter pull requests on the server, not client #240

Merged
merged 3 commits into from
Feb 6, 2021

Conversation

jhosteny
Copy link
Contributor

@jhosteny jhosteny commented Nov 2, 2020

Ensure that the GraphQL query requests PRs matching the desired states,
rather than requesting all PRs and filtering on the client.

Fixes #233

@jhosteny jhosteny changed the title fix: query pull requests on the server, not client fix: filter pull requests on the server, not client Nov 2, 2020
Ensure that the GraphQL query requests PRs matching the desired states,
rather than requesting all PRs and filtering on the client.

Fixes #233
@jhosteny jhosteny force-pushed the fix/limit-query-states branch from 3348987 to f119d22 Compare November 2, 2020 15:15
@jhosteny jhosteny marked this pull request as ready for review November 2, 2020 19:04
@jhosteny jhosteny requested a review from a team as a code owner November 2, 2020 19:04
@spire-allyjweir
Copy link
Contributor

Any progress on this being potentially reviewed and merged? Would love to see this change make it into the project and resolve #233

@vixus0
Copy link
Contributor

vixus0 commented Jan 10, 2021

As the author of the original PR that caused the rate limiting issues, I'd also like to see this merged 😁

Copy link
Contributor

@rickardl rickardl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickardl rickardl merged commit 9ec47e2 into telia-oss:master Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.22.0 - rate limit being exceed
4 participants