Make skip_download a boolean instead of string

[itsdalmo]

Ref: #32 (comment)

[itsdalmo]

I'm a bit confused about why boolean strings vs proper booleans are used interchangeably in other resources, when both source and params seem to support bool just fine. E.g., looking at other resources written in Go:

In the S3 resource:

• skip_download is a string, and they use strconv.ParseBool to convert it to a boolean.
• skip_download is also a parameter in the source configuration... but here it is a boolean.
• And there seems to be no difference between params and source configurations in terms of handling booleans, since the get params also accept a boolean in unpack.

In the concourse pipeline resource, it seems to be the other way around:

• Out params take unpaused as a boolean value.
• But the source configuration expects a boolean string.

But why? 🤷‍♂️

[mikael-lindstrom]

Maybe we should ask/create an issue with concourse to figure this out? Seems very strange.

[itsdalmo]

Vito responded on Discord that true booleans should be fine, no need to use a string and convert it👍

[mikael-lindstrom]

Great, then this LGTM 👍