Feature request: disable_forks parameter #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 12, 2019 13:28
The resource should be able to ignore forks if configured to do so This implements a test for this functionality and gets the tests into a compiling but failing state
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Implement the
disable_forksparameter, which stops the resource from triggering if the pull request's repository is different from the resource's repository.For more information search for
isCrossRepositoryon GitHub's API documentationWhy
I would like to be able to configure the resource to only trigger on pull requests using branches rather than forks. This is so we can use GitHub's collaborator/team permissions instead of doing an author validation step in a task.
Pull request
README.mdOther
This pull request does not implement an end to end test for this functionality, just a unit test. Personally I think that an end-to-end test would just be testing GitHub's implementation.
Please let me know if there is further work that you require before considering this feature.