A fix to allow leading zero on sig values #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poplexity
requested review from
guilledk,
lesa-telos,
coa-telos and
aamirpashaa
poplexity
force-pushed
the
leading_zero_sig
branch
from
d2ac082 to
93bbbb9
Compare
lesa-telos
reviewed
Sep 27, 2024
lesa-telos
reviewed
Sep 27, 2024
| // If we fail to decode with the strict RLP from reth, | ||
| // and we don't have a raw.sender which suggests a native signed trx | ||
| // then try the telos legacy decode without passing a signature | ||
| if signed_legacy_result.is_err() && raw.sender.is_none() { |
There was a problem hiding this comment.
This should be the same without having 2 if checks for signed_legacy_result error
Suggested change
| if signed_legacy_result.is_err() && raw.sender.is_none() { | |
| if signed_legacy_result.is_err() { | |
| if raw.sender.is_none() { | |
| signed_legacy_result = | |
| TxLegacy::decode_telos_signed_fields(&mut raw.tx.clone().as_slice(), None); | |
| } | |
| let address = Address::from( | |
| raw.sender | |
| .expect("Failed to get address from sender in unsigned transaction, signed_legacy_result is Err") | |
| .data, | |
| ); | |
| let sig = make_unique_vrs(block_hash, address, trx_index); | |
| let unsigned_legacy = TxLegacy::decode_telos_signed_fields( | |
| &mut raw.tx.clone().as_slice(), | |
| Some(sig), | |
| )?; | |
| let envelope = TxEnvelope::Legacy(unsigned_legacy); | |
| return Ok(TelosEVMTransaction { envelope, receipt }); | |
| } |
There was a problem hiding this comment.
This does change the behavior, if we decode_telos_signed_fields with a None signature successfully then we don't want to enter the second if block.
lesa-telos
approved these changes
Sep 27, 2024
coa-telos
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.