Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pgrx v0.12.9 and support Postgres 17 #34

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Upgrade to pgrx v0.12.9 and support Postgres 17 #34

merged 1 commit into from
Jan 3, 2025

Conversation

theory
Copy link
Contributor

@theory theory commented Dec 17, 2024

Replace all uses of u32 for OIDs with pgrx::pg_sys::Oid, as IntoDatum no longer has an implementation for u32, as of pgcentralfoundation/pgrx#1354.

Update source_column()'s return value to omit errors for each column, as that pattern is no longer supported as of pgcentralfoundation/pgrx#1708.

@theory theory requested a review from ryw December 17, 2024 19:48
Replace all uses of `u32` for OIDs with `pgrx::pg_sys::Oid`, as
`IntoDatum` no longer has an implementation for `u32`, as of
pgcentralfoundation/pgrx#1354.

Update `source_column()`'s return value to omit errors for each column,
as that pattern is no longer supported as of
pgcentralfoundation/pgrx#1708.
Copy link
Collaborator

@analyzer1 analyzer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: Compiling, running, and testing on PG16 and PG17 indicate no issues associated with these file changes.

@theory theory merged commit 631e194 into main Jan 3, 2025
1 check passed
@theory
Copy link
Contributor Author

theory commented Jan 3, 2025

Thanks. I look forward to the next release publishing to Trunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants