Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove password from ConnectionInfo #697

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conductor/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions conductor/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ pub async fn get_pg_conn(
"app_user_secret".to_string(),
))?;

let (postgres_user, postgres_pw) = get_field_value_from_secret(postgres_data)?;
let (postgres_user, _password) = get_field_value_from_secret(postgres_data)?;
let (app_user, app_pw) = get_field_value_from_secret(app_data)?;

let host = format!("{name}.{basedomain}");
Expand All @@ -303,7 +303,6 @@ pub async fn get_pg_conn(
pooler_host,
port: 5432,
user: postgres_user,
password: postgres_pw,
app_user,
app_password: app_pw,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

};
Expand Down
1 change: 0 additions & 1 deletion conductor/src/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ pub struct ConnectionInfo {
pub pooler_host: Option<String>,
pub port: u16,
pub user: String,
pub password: String,
pub app_user: String,
pub app_password: String,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about app password?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought there is also readonly user, but I'm not sure where that info is

}
Loading