Fix #692 & #615: skb page refcounting, forwarded skb initialization #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. ss_skb_init_for_xmit() initializes forwarded skbs; 3. Protect tcp_v4_connect() -> tcp_connect() by the socket lock to let it finish it's operation before getting response (e.g. ACK) from the peer (crucial for loopback connections sending packets just by function calls); 4. Add assertions to guarantee that socket lock is aquired by current CPU; 5. Many replacements of BUG() assertions by WARN_ON_ONCE() for better reliability. 6. Define TFW_CLASSIFIER_ACCSZ in dependence on CONFIG_DEBUG_LOCK_ALLOC and several other minor fixes and cleanups; I reviewed UDP/datagram code as well and the patch introduces several fixes applicable to datagrams (e.g. skb_morph()), so I believe #615 can be safely closed.
aleksostapenko
approved these changes
Dec 29, 2017
vankoven
approved these changes
Dec 29, 2017
keshonok
reviewed
Dec 29, 2017
| * skb_gro_receive() drops reference to the SKB's header | ||
| * via the __skb_header_release(). So, to not break the | ||
| * things we must take reference back. | ||
| */ |
There was a problem hiding this comment.
Frankly, I believe that original placement of this comment was better. This is a small piece of code, and it looks dense, nice, and very readable. The comment explains what happens in the logical block of code that follows it, and it's sufficient for understanding the block of code. Placing multi-line comment in the middle of it just dilutes this small block of code and makes it a bit more difficult to follow.
I know that this may be a matter of taste. :-) I believe the code in the kernel in general is written more like to what I describe above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Server failovering may cause crashes under load or during getting of perfstat #692 in the kernel.
ss_skb_init_for_xmit() initializes forwarded skbs;
Protect tcp_v4_connect() -> tcp_connect() by the socket lock to let it
finish it's operation before getting response (e.g. ACK) from the peer
(crucial for loopback connections sending packets just by function calls);
Add assertions to guarantee that socket lock is aquired by current CPU;
Many replacements of BUG() assertions by WARN_ON_ONCE() for better
reliability.
Define TFW_CLASSIFIER_ACCSZ in dependence on CONFIG_DEBUG_LOCK_ALLOC
and several other minor fixes and cleanups;
I reviewed UDP/datagram code as well and the patch introduces several
fixes applicable to datagrams (e.g. skb_morph()), so I believe #615 can be safely closed.