New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color mode switcher always visible in Sticky Header #660

Closed

GeoffroyVD opened this issue Apr 23, 2024 · 2 comments · Fixed by #673

Milestone

GeoffroyVD commented Apr 23, 2024 •

edited

Loading

The color mode switcher for (Light/Dark Theme) is always visible in the Sticky Header also when you define a module position of hidden or COM_MODULES_NONE. For Astroid Template Zero and Astroid Template Two

For my configuration with Astroid Template Zero it is coming twice in the Sticky Header when I define it in position topbar-2 or header-right like defined in Header section configuration.

See the different screenshots of the configurations.

sonvnn added a commit that referenced this issue


          Fix issue Color mode switcher always visible in Sticky Header #660

cbb319a

Member

sonvnn commented May 13, 2024

Dear @GeoffroyVD

Thanks for report issue. I fixed this at cbb319a

Please help me download v3-branch and re-test again.

Best Regards,
Sonny

sonvnn added this to the Version 3.0.15 milestone

sonvnn added this to Astroid Framework

sonvnn linked a pull request

that will close this issue

Merged

Author

GeoffroyVD commented May 14, 2024

It is working like expected.
Thanks for the quick fix of it.

THX,
@GeoffroyVD

GeoffroyVD closed this as completed

github-project-automation bot moved this to Done in Astroid Framework

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment