Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmoothScroll is not working anymore #860

Closed
Joomlaplates opened this issue Nov 1, 2024 · 13 comments · Fixed by #853
Closed

SmoothScroll is not working anymore #860

Joomlaplates opened this issue Nov 1, 2024 · 13 comments · Fixed by #853
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Joomlaplates
Copy link
Collaborator

Astroid 3.1.7
Template TWO
Joomla 5.2
..
The Smoothscroll from menu is not working anymore.
https://compassionate-bardeen.85-214-95-104.plesk.page/

Regards Peter

@Joomlaplates
Copy link
Collaborator Author

You can fix it with adding following code, see picture
scroll
The script found on Codepen
https://codepen.io/cferdinandi/pen/wQzrdM

@WM-Loose
Copy link

WM-Loose commented Nov 3, 2024

I can confirm this and Peter's solution works.
Until it is solved, all our customers should deactivate Smoothscroll.

@WM-Loose
Copy link

WM-Loose commented Nov 5, 2024

It works with Chrome and Edge.
So we checked Firefox again and found that the smooth gliding function was not activated there.
After activating it, it now works in Firefox too.

FF
options /surfing / smooth gliding = on

@sonvnn
Copy link
Member

sonvnn commented Nov 6, 2024

@Joomlaplates @WM-Loose I am sorry that I cannot reproduce the issue you mentioned on Chrome, Firefox, Safari. I have tried on different computers in my company and cannot find the problem here. Can you please help me create a video recording the problems on your screen. This will help me to know how to find the problem more clearly.

@tmumm
Copy link

tmumm commented Nov 6, 2024

I've found the same thing, you can see on my test site: https://capture.dropbox.com/oZ5sLSd6D25iYAjE
That was me scrolling down as normal on the site here: https://www.thirdsun.site/
This is only an issue in Chrome for me.

@sonvnn
Copy link
Member

sonvnn commented Nov 7, 2024

@Joomlaplates @WM-Loose @tmumm I fixed this issue at 0dade23
I also brought the Scroll Speed option back.
Please help me download v3-branch and retest again. Hope you like it.

@sonvnn sonvnn linked a pull request Nov 7, 2024 that will close this issue
@sonvnn sonvnn added the bug Something isn't working label Nov 7, 2024
@sonvnn sonvnn moved this to In review in Astroid Framework Nov 7, 2024
@sonvnn sonvnn added this to the Version 3.1.8 milestone Nov 7, 2024
@WM-Loose
Copy link

WM-Loose commented Nov 7, 2024

Test positiv :-)
Now it works as it should.

@Joomlaplates
Copy link
Collaborator Author

Yes it working now.
Thank you Sonny

@WM-Loose
Copy link

WM-Loose commented Nov 8, 2024

Hi Sonny,
I just realized that there is still a problem. If smoothscroll is activated, scrolling with mousewheel in the offcanvas window no longer works. Only when smoothscroll is deactivated can you scroll up and down in the offcanvas window again with the mouse wheel.
Unfortunately, I only just noticed it.

@sonvnn
Copy link
Member

sonvnn commented Nov 8, 2024

Thank you! I will check it and response asap

@sonvnn
Copy link
Member

sonvnn commented Nov 11, 2024

@WM-Loose I fixed issue of Smooth Scroll on Off Canvas at 38b57be

Please help me download v3-branch and retest it.

@WM-Loose
Copy link

It works perfectly now. Thank you very much Sonny.
But I had to find the path to the PHP file first :-) For all users who don't want to search.
The PHP file is here: myjoomla/libraries/astroid/framework/frontend/offcanvas.php
Sonny, you are great and solved it quickly as always.

@Joomlaplates
Copy link
Collaborator Author

Hi Sonny, yes its working now.
Thank you so much

@github-project-automation github-project-automation bot moved this from In review to Done in Astroid Framework Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants