Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CDN and Local js files options to Fontawesome load #598

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

uzielweb
Copy link

@uzielweb uzielweb commented Mar 7, 2024

No description provided.

@Chacapamac
Copy link
Collaborator

Is this 300 files added for have the ability to load Awesome Locally?
Not sure if it’s a good idea to include all these files.
Include the ability for users to switch to local Icons, Yes, but, like the Custom Local fonts, they should install them manually, only if they need them.

Can somebody explain why?

@uzielweb
Copy link
Author

uzielweb commented Mar 10, 2024

Custom SVGs are used for Font Awesome instead of traditional fonts when utilizing JS Local FontAwesome These SVGs are loaded individually, for instance, when you use the code , it gets dynamically replaced on-the-fly with the actual SVG code during runtime. Is better that load entire fonts to show only "2 or more" icons by page.
Local fonts are not "installed" in the user computer, but loaded in a single time for session.
Local SVG are loaded in every connection by session individually instead entire font files.

@Chacapamac
Copy link
Collaborator

@uzielweb Seem to be a good thing, I guess it’s probably easy to implement, a bit like “Custom Local Fonts”?
— Downloads the SVGs
— Download a JS file and link and load all that

Its probably a good reason why the merging of this is block?
What you think is the problem, Size, maintenance of the libraries, usability?

@uzielweb
Copy link
Author

OK, so optional dowload svg package is a good idea too, but offer CDN JS uses zero megabytes in the package, I thing.
This is an idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants