Refactor handleWorkflowTaskCompleted retry loop #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
approved these changes
Feb 11, 2022
alexshtin
force-pushed
the
feature/refactor-wtc-retry-loop
branch
from
c53187d to
c632505
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Remove one of two
continuecondition of the retry loop and narrow it to few lines instead of x hundred lines.Why?
To prevent unnecessary retries in case of failed workflow execution updates.
How did you test it?
Existing tests.
Potential risks
Under some specific conditions, if workflow update failed it won't be retried. SDKs though will retry.
Is hotfix candidate?
Yes.