Fix DeleteWorkflowExecution API when delete non current execution #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
Feb 11, 2022
yycptt
reviewed
Feb 11, 2022
| @@ -54,7 +53,7 @@ type ( | |||
| ) error | |||
| GenerateDeleteExecutionTask( | |||
| now time.Time, | |||
| ) error | |||
| ) (*tasks.DeleteExecutionTask, error) | |||
There was a problem hiding this comment.
return tasks.Task or []tasks.Task please.
Once queue refactor change is done, I am going to update all the generator methods to return the generated task, instead of adding it to ms directly.
There was a problem hiding this comment.
"Depend on interface, return concrete type", right? Unless there is a good reason for exception.
There was a problem hiding this comment.
Since we control the caller code and we can prevent them from being closely coupled, I don't really have a strong opinion here.
yycptt
reviewed
Feb 11, 2022
|
I was sure I merged this PR already. |
alexshtin
force-pushed
the
feature/fix-delete-workflow-execution
branch
from
a73eeeb to
0efa1eb
Compare
yycptt
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix
DeleteWorkflowExecutionAPI when delete non current execution. Instead of calling internalupdateWorkflowfuncion, adding transfer task using newDeleteManager.AddDeleteWorkflowExecutionTaskfunction which essentially just callsshard.AddTask.Why?
Previous implementation worked only for current workflows.
How did you test it?
Integration test in another PR.
Potential risks
No risks.
Is hotfix candidate?
No.