Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define type and name for task categories #2522

Merged
merged 1 commit into from
Feb 19, 2022
Merged

Define type and name for task categories #2522

merged 1 commit into from
Feb 19, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Feb 19, 2022

What changed?

  • Define type and name for task categories. Instead of just an integer, task category is now a struct with ID, type and name.

Why?
#2511 (comment)

How did you test it?
Existing tests

Potential risks

Is hotfix candidate?
no

@yycptt yycptt requested review from yux0 and yiminc February 19, 2022 00:44
@yycptt yycptt requested a review from a team as a code owner February 19, 2022 00:44
@yycptt yycptt merged commit 2e69c93 into temporalio:master Feb 19, 2022
@yycptt yycptt deleted the task-category-as-struct branch February 19, 2022 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiminc yiminc yiminc approved these changes

@wxing1292 wxing1292 wxing1292 approved these changes

@yux0 yux0 Awaiting requested review from yux0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yycptt @wxing1292 @yiminc