Update interfaces and structs for admin use #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
approved these changes
Feb 23, 2022
yycptt
reviewed
Feb 23, 2022
service/history/timerQueueAckMgr.go
Outdated
| } | ||
|
|
||
| func newTimerKey(time time.Time, taskID int64) *timerKey { | ||
| func NewTimerKey(time time.Time, taskID int64) *timerKey { |
There was a problem hiding this comment.
Shall we deprecate the TimerKey and use tasks.Key instead?
There was a problem hiding this comment.
Yes. Good to know. I will update this.
yux0
added a commit
that referenced
this pull request
Feb 23, 2022
* Update interface and struct for admin use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Update interfaces and structs for admin use
Why?
Expose those interfaces and structs for future admin use
How did you test it?
No logic changed
Potential risks
Is hotfix candidate?