Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sql task queue visibility #2537

Merged
merged 2 commits into from
Feb 25, 2022
Merged

Sql task queue visibility #2537

merged 2 commits into from
Feb 25, 2022

Conversation

jbreiding
Copy link
Contributor

@jbreiding jbreiding commented Feb 24, 2022

What changed?
Added TaskQueue to SQL VisibilityRow implementation
Updated read and write paths converting from Request/Response to pass through TasQueue.

Why?
Completeness of api implementation and consistency
#2207

How did you test it?
Local tests and updated unit test

Potential risks
N/A

Is hotfix candidate?
No

@jbreiding jbreiding requested a review from a team as a code owner February 24, 2022 15:50
@jbreiding jbreiding linked an issue Feb 24, 2022 that may be closed by this pull request
@jbreiding jbreiding closed this Feb 25, 2022
@jbreiding jbreiding reopened this Feb 25, 2022
@jbreiding jbreiding merged commit f92cc93 into temporalio:master Feb 25, 2022
@jbreiding jbreiding deleted the sql-task-queue-visibility branch February 25, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQLite persistence not returning WorkflowExecutionInfo.task_queue
3 participants