Fix unloading shard after task id sanity check #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
approved these changes
Mar 4, 2022
| // stop should only be called by the controller. | ||
| func (s *ContextImpl) stop() { | ||
| // finishStop should only be called by the controller. | ||
| func (s *ContextImpl) finishStop() { |
There was a problem hiding this comment.
I usually name the method start with _ if i don't want others to call it, so it would be _stop(). That way, when people make calls to it, they will look closer.
But i'm not sure if that is best practice.
There was a problem hiding this comment.
That feels like a Python idiom to me. There aren't any methods or functions named with initial underscore in this repo, except for some proto-generated code. I think this is fine (after fixing the test).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
In #2361, the shard would get unloaded without going through the controller, which would leave it in the controller's map in a stopped state. This makes it go through the controller. Also renamed the stop method to make it less confusing.
Why?
The consequences are pretty benign for now (wrong metrics on number of shards loaded/unloaded), but could be worse if the interaction between controller and context gets more complex.
How did you test it?
new unit test
Potential risks
Is hotfix candidate?