Rename namespace persistence API #2595
Conversation
|
|
||
| if !applied { | ||
| // TODO: Update namepspaces_by_id to previous name before returning error??? | ||
| return serviceerror.NewUnavailable(fmt.Sprintf("RenameNamespace operation failed because of conditional failure.")) |
There was a problem hiding this comment.
this should be an CAS related error?
There was a problem hiding this comment.
yes, notification_version in metadata row is also update there.
|
|
||
| // Does almost everything in one batch. The only separate thing is namespaecs_by_id update which is almost not used now. | ||
| // Can be retried but data between steps is inconsistens (points to the name which doesn't exist). | ||
| func (m *MetadataStore) RenameNamespace1(request *p.InternalRenameNamespaceRequest) error { |
There was a problem hiding this comment.
i would prefer option 1
the additional namespace ID -> namespace name mapping is to ensure namespace ID being unique
the ID -> name mapping (DB table) is not used according to my memory
the ID -> name lookup is done by namespace cache
- loading all namespace from
namespacestable - index ID -> name using above records
There was a problem hiding this comment.
could you add some comment about the namespaces_by_id table? thanks
btw, to successfully achieve the namespace renaming functionality, we need to guarantee only IDs are used within service boundary
There was a problem hiding this comment.
I improved comment here. I can't expose RenameNamespace as public API for now. I added it only to support namespace deletion.
What changed?
Rename namespace persistence API.
Why?
To be able to rename namespaces internally.
How did you test it?
New unit test.
Potential risks
No risks.
Is hotfix candidate?
No.