Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make matching persistence range queries [inclusive, exclusive) #2599

Merged
merged 3 commits into from
Mar 15, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Mar 10, 2022

What changed?

  • Range for matching GetTasks is now [inclusive, exclusive), instead of (exclusive, inclusive]
  • Range for matching CompleteTasksLessThan is now < max TaskID, instead of <=. This also matches the method name.

Why?
#2587

  • Match the range for history task range queries

How did you test it?
Existing tests

Potential risks
In worst case, may miss some tasks when getting/deleting matching tasks.

Is hotfix candidate?
no

@yycptt yycptt requested a review from yiminc March 10, 2022 22:53
@yycptt yycptt requested a review from a team as a code owner March 10, 2022 22:53
@yycptt yycptt force-pushed the matching-inclusive-exclusive branch from dc9e350 to 36d4aa6 Compare March 10, 2022 23:02
service/frontend/adminHandler.go Outdated Show resolved Hide resolved
@yycptt yycptt merged commit bb7b984 into temporalio:master Mar 15, 2022
@yycptt yycptt deleted the matching-inclusive-exclusive branch March 15, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants