Fix parent close policy processor for deleted namespace #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
force-pushed
the
fix/missing-child-workflow
branch
from
a2c3a26 to
dd07122
Compare
alexshtin
commented
Mar 29, 2022
Comment on lines
+1401
to
+1402
| case nil: | ||
| case *serviceerror.NotFound: |
yycptt
reviewed
Mar 29, 2022
| switch err.(type) { | ||
| case nil, *serviceerror.NotFound: | ||
| case nil: | ||
| case *serviceerror.NotFound: |
There was a problem hiding this comment.
Fix the request cancel case below as well?
There was a problem hiding this comment.
Updated unit test also.
yiminc
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix parent close policy processor for deleted namespace.
Why?
Due to bug,
TerminateWorkflowwas still called even if namespace is deleted and not found in namespace registry.How did you test it?
New unit test.
Potential risks
No risks.
Is hotfix candidate?
No.