Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move commonly used get & update function to api package #3311

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Move commonly used get & update function to api package #3311

merged 2 commits into from
Sep 7, 2022

Conversation

wxing1292
Copy link
Contributor

What changed?

  • Move commonly used get & update function to api package
    • Update history engine & workflow task handler accordingly

Why?
Better code structure

How did you test it?
N/A

Potential risks
N/A

Is hotfix candidate?
N/A

@wxing1292 wxing1292 requested review from yux0, yycptt and yiminc September 6, 2022 17:59
@wxing1292 wxing1292 requested a review from a team as a code owner September 6, 2022 17:59
yycptt
yycptt approved these changes Sep 7, 2022
View reviewed changes
Makefile Show resolved Hide resolved
service/matching/taskqueue.go Outdated Show resolved Hide resolved
@wxing1292 wxing1292 enabled auto-merge (squash) September 7, 2022 19:40
@wxing1292 wxing1292 merged commit 44ee560 into temporalio:master Sep 7, 2022
@wxing1292 wxing1292 deleted the api-isolatio-1 branch September 7, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yycptt yycptt yycptt approved these changes

@yux0 yux0 Awaiting requested review from yux0

@yiminc yiminc Awaiting requested review from yiminc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wxing1292 @yycptt