Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current Details #2466

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Current Details #2466

merged 3 commits into from
Dec 9, 2024

Conversation

Alex-Tideman
Copy link
Contributor

@Alex-Tideman Alex-Tideman commented Dec 6, 2024

Description & motivation 💭

We currently fetch the workflow metadata query on page load to get the list of signals/queries. This also includes the current details. Add a "Current Details" accordion to show the current details if they exist. So a Workflow can have:

  1. Summary & Details
  2. Current Details
  3. Both 1 & 2
  4. Neither 1 & 2

Current details can only be set in code with an SDK, not through the UI.

Screenshots (if applicable) 📸

Screenshot 2024-12-06 at 9 11 50 AM Screenshot 2024-12-06 at 12 38 44 PM Screenshot 2024-12-06 at 12 39 14 PM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@Alex-Tideman Alex-Tideman requested review from rossedfort and a team as code owners December 6, 2024 19:06
Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 6:00pm

@Alex-Tideman Alex-Tideman merged commit c1117f3 into main Dec 9, 2024
14 checks passed
@Alex-Tideman Alex-Tideman deleted the current-details branch December 9, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants