This repository has been archived by the owner on Feb 23, 2022. It is now read-only.
proto: rename timing params to synchrony params #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williambanfield
requested review from
ebuchman,
josef-widder,
konnov and
milosevic
as code owners
creachadair
reviewed
Jan 10, 2022
creachadair
approved these changes
Jan 10, 2022
cmwaters
approved these changes
Jan 11, 2022
cason
approved these changes
Jan 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request renames the PBTS parameters from
TimingParamstoSynchronyParams. This name more specifically reflects what the parameters are for. Additionally, another set of consensus parameters are planned to be added calledTimeoutParamsas part of the work for ADR-74. The similarity of these names will definitely cause confusion so changing this name seems like a good fix.