feat: build image by platform

[n063h]

refer to #1580

Before

Hardcoded linux/amd64 platform into code, so envd builds image on linux/amd64 platform by default.

After

support --platform flag to build image on target platform.

[pingsutw]

@n063h Thanks for working on this. Any update for it. we need muti-arch image. I can help for testing

[n063h]

@n063h Thanks for working on this. Any update for it. we need muti-arch image. I can help for testing

@pingsutw Thanks for reaching out! There's a small hiccup with the dependency "horust" image that I'm working on fixing. I'll get it sorted out soon.

[n063h]

@pingsutw Hi, sorry for the wait, I think this branch is ready for your test now. You can run envd build --platform linux/amd64,linux/arm64 to build multi-platform images.
Since I have no machine on Non-x86 platforms, I tested it with qemu on linux/arm64 which worked well.
Please note: horust now provides only linux/amd64,linux/arm64 images, so the images built from envd also work just for the two platforms.

[kemingy]

Is it ready to review?

BTW the dev env only work for aarch64/amd64, but the non-dev env should work for more platforms.

[n063h]

Is it ready to review?

BTW the dev env only work for aarch64/amd64, but the non-dev env should work for more platforms.

yes.
And the default target-platform is "linux/amd64" no matter what the build-platform is, which may require explicitly flag for arch arm64 for macos users.

[gaocegege]

/cc @kemingy

[kemingy]

LGTM. Please resolve the conflicts.

[pingsutw]

could we also update the platform for NewImageSource

sys := types.SystemContext{}
if platform != nil {
  sys.ArchitectureChoice = platform.Architecture
  sys.OSChoice = platform.OS
}
src, err := ref.NewImageSource(ctx, &sys)

[n063h]

could we also update the platform for NewImageSource

sys := types.SystemContext{}
if platform != nil {
  sys.ArchitectureChoice = platform.Architecture
  sys.OSChoice = platform.OS
}
src, err := ref.NewImageSource(ctx, &sys)

What is the purpose of these changes,a re there any issues with the current code? @pingsutw

[pingsutw]

It will pull the base image. I'm using envd in my macbook. It still tries to pull darwin/amd64 base image, although I set the platform to linux/amd64, so we also need to update the platform for NewImageSource.
#1587

[n063h]

It will pull the base image. I'm using envd in my macbook. It still tries to pull darwin/amd64 base image, although I set the platform to linux/amd64, so we also need to update the platform for NewImageSource. #1587

I got you, the update has been pushed.

[pingsutw]

LGTM, thank you

[pingsutw]

btw, @kemingy could you help me cut a release after it merges? I need to bump envd version in flytekit.

[kemingy]

btw, @kemingy could you help me cut a release after it merges? I need to bump envd version in flytekit.

https://github.com/tensorchord/envd/releases/tag/v0.3.22 is released