Skip to content

Commit

Permalink
Do not try to download and prepare a dataset if it's a read only builder
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 718860563
  • Loading branch information
tomvdw authored and The TensorFlow Datasets Authors committed Jan 23, 2025
1 parent f5677a4 commit 3a40e2c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tensorflow_datasets/core/load.py
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,9 @@ def _download_and_prepare_builder(
download_and_prepare_kwargs: Optional[dict[str, Any]],
) -> None:
"""Downloads and prepares the dataset builder if necessary."""
if isinstance(dbuilder, read_only_builder.ReadOnlyBuilder):
# read only builder can't be used to download and prepare datasets.
return
if dbuilder.is_prepared():
if not download_and_prepare_kwargs:
return
Expand Down
1 change: 1 addition & 0 deletions tensorflow_datasets/core/utils/version_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
class VersionTest(testing.TestCase):

def test_str_to_version(self):
self.assertEqual(version._str_to_version('0.0.0'), (0, 0, 0))
self.assertEqual(version._str_to_version('1.2.3'), (1, 2, 3))
self.assertEqual(version._str_to_version('1.2.*', True), (1, 2, '*'))
self.assertEqual(version._str_to_version('1.*.3', True), (1, '*', 3))
Expand Down

0 comments on commit 3a40e2c

Please sign in to comment.