Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to update version of fmt library to 11.0.1+ in tt-umd #10087

Closed
dongjin-na opened this issue Jul 10, 2024 · 0 comments · Fixed by tenstorrent/tt-umd#17
Closed

Request to update version of fmt library to 11.0.1+ in tt-umd #10087

dongjin-na opened this issue Jul 10, 2024 · 0 comments · Fixed by tenstorrent/tt-umd#17
Assignees
Labels
feature-request External feature request moreh moreh contribution P1

Comments

@dongjin-na
Copy link
Contributor

dongjin-na commented Jul 10, 2024

Is your feature request related to a problem? Please describe.
The fmt library sets namespaces according to its major versions (e.g., version 10.2.1 uses namespace v10), resulting in different symbols for different versions.
However, fmt version 11.0.0 uses the same namespace as major version 10.
In other words, fmt version 10.0.0 ~ 10.2.1 use namespace v10 and fmt version 11.0.0 also uses namespace v10 (this is mistake of fmt contributors).

As a result, it leads to an ODR (One Definition Rule) violation.
A segmentation fault can occur when incorrect symbols are linked in external projects that use different versions of fmt.

Describe the solution you'd like
If the version of fmt in tt-umd is updated to 11.0.1, it will use the correct namespace (v11) as described in fmtlib issue #4047.
This update will resolve the potential segmentation fault by ensuring the correct symbols linkage.

@dongjin-na dongjin-na added feature-request External feature request moreh moreh contribution labels Jul 10, 2024
@razorback3 razorback3 changed the title Request to Update fmt to 11.0.1 in tt-umd Request to update version of fmt library to 11.0.1+ in tt-umd Jul 10, 2024
@razorback3 razorback3 added P0 P1 and removed P0 labels Jul 10, 2024
@joelsmithTT joelsmithTT reopened this Jul 10, 2024
joelsmithTT added a commit that referenced this issue Jul 10, 2024
tt-umd's fmt has been updated to 11.0.1 from 11.0.0.
11.0.0 contained a namespace related defect.
joelsmithTT added a commit that referenced this issue Jul 11, 2024
tt-umd's fmt has been updated to 11.0.1 from 11.0.0.
11.0.0 contained a namespace related defect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request External feature request moreh moreh contribution P1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants