Add fortinet-fortigate package #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
approved these changes
Oct 30, 2024
Co-authored-by: Dominik Lohmann <[email protected]>
Co-authored-by: Dominik Lohmann <[email protected]>
Co-authored-by: Dominik Lohmann <[email protected]>
Co-authored-by: Dominik Lohmann <[email protected]>
Co-authored-by: Dominik Lohmann <[email protected]>
Co-authored-by: Dominik Lohmann <[email protected]>
Co-authored-by: Dominik Lohmann <[email protected]>
| | parse content kv | ||
| | yield content | ||
| | set #schema = "fortinet.fortigate" | ||
| | publish "fortinet" |
There was a problem hiding this comment.
Nitpicky comment: This file here has no newline at its end, as indicated by the icon here. Usually, it's considered good practice to end all files with a newlines. You can configure your text editor to automatically do that for you, too.
I'll take care of this now as part of signing the commits, but keep it in mind for the next one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This the first draft for the fortinet-fortigate package which I prepared together with Dominik. Examples are still missing.