Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error for invalid -l | -o options on the early stage instead of getting a cryptic error #190

Conversation

EmilyGraceSeville7cf
Copy link
Contributor

This is my first PR here. :)

@agnostic-apollo
Copy link
Member

Thanks for the validation checks.

I have fixed the following issues:

  • Errors should be sent to stderr.
  • Exit code via show_usage should not be 0 for errors.
  • The help output would show the invalid value of $PARAM_LIMIT or $PARAM_OFFSET that was overridden instead of the default value.
  • Variables should be quoted to prevent whitespace splitting.

Kindly test the changes as I have not. Will squash and merge once that is done.

@EmilyGraceSeville7cf
Copy link
Contributor Author

It seems to work as expected. 😄

@agnostic-apollo agnostic-apollo force-pushed the feature/enhance-error-handling branch from 0515548 to 00d5818 Compare December 24, 2024 19:24
@agnostic-apollo agnostic-apollo merged commit 4253eb2 into termux:master Dec 24, 2024
@agnostic-apollo
Copy link
Member

Thanks. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants